fix: do not err on process exit #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
hdp617
suggested changes
May 22, 2020
hdp617
reviewed
Jun 3, 2020
| process.on('exit', code => { | ||
| logAndSendError(new Error(`Process exited with code ${code}`), latestRes); | ||
| process.on('SIGINT', code => { | ||
| console.log(`Process exited with code ${code}`); | ||
| }); | ||
|
|
||
| ['SIGINT', 'SIGTERM'].forEach(signal => { |
There was a problem hiding this comment.
SIGINT is also handled here. Could you please update this?
| @@ -258,8 +258,8 @@ export class ErrorHandler { | |||
| logAndSendError(err, latestRes, killInstance); | |||
| }); | |||
|
|
|||
| process.on('exit', code => { | |||
There was a problem hiding this comment.
I think this would remove error logging when the process exits from user's function.
I do think we should not log and send error when process exits normally though. How about checking the status code and only logAndSendError for non-0 ones? Or handing SIGINT before exit?
|
@grant What's the status of this PR? |
I don't know how to test this change, don't want to break GCF, and haven't continued with it. |
|
This PR is outdated and fixed with #126. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #22 #143
This change the behavior the process exit event handler.
I don't know exactly why we have a
latestResmodification here or if it's needed. I would assume a process exit does not need to send the latest HTTP response as an exit would not naturally happen.Before
Serving function... Function: function URL: http://localhost:8080/ ^CReceived SIGINT Error: Process exited with code 0 at process.<anonymous> (<folder>/node_modules/@google-cloud/functions-framework/build/src/invoker.js:396:29) at process.emit (events.js:203:13) at process.EventEmitter.emit (domain.js:471:20) at process.exit (internal/process/per_thread.js:158:15) at Server.<anonymous> (<folder>/node_modules/@google-cloud/functions-framework/build/src/invoker.js:402:29) at Object.onceWrapper (events.js:291:20) at Server.emit (events.js:203:13) at Server.EventEmitter.emit (domain.js:471:20) at emitCloseNT (net.js:1572:8) at processTicksAndRejections (internal/process/task_queues.js:77:11)After