Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prototype cloudevent function signature type #147

Merged
merged 9 commits into from
Jun 5, 2020
Merged

feat: prototype cloudevent function signature type #147

merged 9 commits into from
Jun 5, 2020

Conversation

hdp617
Copy link
Contributor

@hdp617 hdp617 commented Jun 3, 2020

No description provided.

@hdp617 hdp617 requested a review from grant June 3, 2020 20:01
grant
grant approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have a couple comments we should look at before merging.

src/index.ts Outdated Show resolved Hide resolved
src/invoker.ts Outdated Show resolved Hide resolved
src/invoker.ts Outdated Show resolved Hide resolved
grant
grant suggested changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need README changes.

This was referenced Jun 3, 2020
Closed
Closed
Closed
Closed
Closed
Closed
@hdp617
Copy link
Contributor Author

hdp617 commented Jun 4, 2020

Updated README. Could you PTAL?

grant
grant suggested changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested a few changes.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
test/invoker.ts Outdated Show resolved Hide resolved
test/invoker.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
test/invoker.ts Show resolved Hide resolved
grant
grant approved these changes Jun 5, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@hdp617 hdp617 merged commit a224c13 into GoogleCloudPlatform:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grant grant grant approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hdp617 @grant @googlebot