Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): Replace --target with --function-target #18

Closed
wants to merge 1 commit into from

Conversation

anishkny
Copy link

Otherwise it errors:

$ npx @google-cloud/functions-framework --target=helloWorld
Function 'function' is not defined in the provided module.
Did you specify the correct target function to execute?
Could not load the function, shutting down.

Otherwise it errors:

```
$ npx @google-cloud/functions-framework --target=helloWorld
Function 'function' is not defined in the provided module.
Did you specify the correct target function to execute?
Could not load the function, shutting down.
```
@grant
Copy link
Contributor

grant commented Apr 18, 2019

Please create an issue before a PR.

It looks like we need to publish to npm for the README instructions to be correct.

You're looking at the previous version on npm. master in this repo has instructions that work when installing locally.


We should publish the npm package after merging commits @swalkowski.

@anishkny
Copy link
Author

Filed issue. Fixes #19

I was looking at README on master on GitHub here.

@stew-r
Copy link
Contributor

stew-r commented Apr 18, 2019

We appreciate the issue & PR -- thanks for proactively finding a solution. Unfortunately, this is currently a mismatch between the (correct) docs and the latest version of our package. We're moving to 1.1.0 which replaces function-target with the shorter target CLI arg.

Based on that, I will close this PR.

@stew-r stew-r closed this Apr 18, 2019
@anishkny
Copy link
Author

Sure no hard feelings. Just trying to help out 😉

@stew-r
Copy link
Contributor

stew-r commented Apr 18, 2019

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants