Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not send error when error code is fine #187

Merged
merged 3 commits into from
Aug 5, 2020
Merged

fix: do not send error when error code is fine #187

merged 3 commits into from
Aug 5, 2020

Conversation

grant
Copy link
Contributor

@grant grant commented Aug 5, 2020 •
edited

Doesn't log assuming an error on process.exit. Keeps same functionality.
Tested locally.

 npx @google-cloud/functions-framework --target=helloWorld

Serving function...
Function: helloWorld
URL: http://localhost:8080/
^CReceived SIGINT

Not sure about upstream impact.

@grant
fix: do not send error when error code is fine
90bf1d3 
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant grant requested a review from hdp617 August 5, 2020 20:14
@grant grant self-assigned this Aug 5, 2020
@google-cla google-cla bot added the cla: yes label Aug 5, 2020
@grant
fix: silent exit on process exit
87cf611 
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
hdp617
hdp617 reviewed Aug 5, 2020
View reviewed changes
src/invoker.ts Outdated Show resolved Hide resolved
@grant
fix: fix logic to only be silent when code is 0
b736c7a 
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant grant merged commit d616c4c into master Aug 5, 2020
@grant grant deleted the grant_exit branch August 5, 2020 21:17
This was referenced Aug 5, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdp617 hdp617 hdp617 approved these changes

Assignees

@grant grant

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grant @hdp617