Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call the function after a 404 on /{robots.txt,favicon.ico} #193

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Conversation

kkm000
Copy link
Contributor

@kkm000 kkm000 commented Aug 9, 2020

Other changes:

  • Send an empty response body for the same with the 404, since these URLs are not intended for human consumption.
  • Add an invocation count assertion to the test to confirm that these URLs do not in fact result in the function call.
  • Accept npm's lockfile update of this own package version.
  • Nit: wrap long comments at 80 characters.

Fixes: #191

Other changes:
 * Send an empty response body for the same with the 404, since
   these URLs are not intended for human consumption.
 * Add an invocation count assertion to the test to confirm that
   these URLs do not in fact result in the function call.
 * Accept npm's lock of this package version as test dependency.
 * Nit: wrap long comments at 80 characters.

Fixes: #191
@google-cla google-cla bot added the cla: yes label Aug 9, 2020
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Tests look great.

@grant grant merged commit 69b5f1e into GoogleCloudPlatform:master Aug 10, 2020
@kkm000
Copy link
Contributor Author

kkm000 commented Aug 10, 2020

My pleasure, thanks! I need to learn the thing anyway. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requesting /favicon.ico URL invokes function, ignores its response, logs error to console
2 participants