Add a source flag/env option to add flexibility to execution path #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squee1945
reviewed
Jul 8, 2019
README.md
Outdated
| @@ -147,6 +147,7 @@ Command-line flag | Environment variable | Description | |||
| `--port` | `PORT` | The port on which the Functions Framework listens for requests. Default: `8080` | |||
| `--target` | `FUNCTION_TARGET` | The name of the exported function to be invoked in response to requests. Default: `function` | |||
| `--signature-type` | `FUNCTION_SIGNATURE_TYPE` | The signature used when writing your function. Controls unmarshalling rules and determines which arguments are used to invoke your function. Default: `http`; accepted values: `http` or `event` | |||
| `--source` | `SOURCE` | The path of your project directory where you want to start. Functions framework always look only at root path, setting this option will look for your function in any other folder. Default: `/` | |||
There was a problem hiding this comment.
Env variable needs to be prefixed: FUNCTION_SOURCE
squee1945
reviewed
Jul 8, 2019
src/index.ts
Outdated
| }; | ||
|
|
||
| // Supported environment variables | ||
| const ENV = { | ||
| PORT: 'PORT', | ||
| TARGET: 'FUNCTION_TARGET', | ||
| SIGNATURE_TYPE: 'FUNCTION_SIGNATURE_TYPE', // underscore | ||
| SOURCE: 'SOURCE', |
|
Hey @NotAPineapple and @squee1945. Before we continue, can we discuss this feature request in a GitHub issue? This new feature has larger implications than just this library. |
grant
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
In my use of Cloud Functions, i've encountered with the situation of using different folders to hold my functions, so this will be helpful for me and any others.