Docs: Add Docker Tutorial Doc #58
Conversation
docs/docker.md
Outdated
|
|
||
| ## Deploy a Container | ||
|
|
||
| You can deploy your containerized function to Cloud Run or any Knative-based environment by following the [Cloud Run quickstart](https://cloud.google.com/run/docs/quickstarts/build-and-deploy). |
There was a problem hiding this comment.
Cloud Run or Cloud Run on GKE. Other knative instances are managed with kubectl or in the future kn. Instructions for knative in that case will also need a service.yaml.
There was a problem hiding this comment.
What would you like me to say instead of Cloud Run?
Does Cloud Run not include Cloud Run on GKE?
Can you suggest a change?
There was a problem hiding this comment.
This is for Cloud Run only: https://cloud.google.com/run/docs/quickstarts/build-and-deploy
This shows how to build and deploy an existing container image to Cloud Run on GKE: https://cloud.google.com/run/docs/quickstarts/prebuilt-deploy-gke
Deploying to Knative anywhere
https://knative.dev/docs/install/getting-started-knative-app/
There was a problem hiding this comment.
I've removed the mention of Cloud Run on GKE.
|
|
||
| ```sh | ||
| docker build -t gcr.io/$GOOGLE_CLOUD_PROJECT/helloworld . | ||
| docker push gcr.io/$GOOGLE_CLOUD_PROJECT/helloworld |
There was a problem hiding this comment.
Note docker push requires some extra steps to get docker authenticating with GCP. In fact, if you use Cloud Build you don't need to get docker working locally at all.
Here are some Cloud Run-specific docs on build options
There was a problem hiding this comment.
How do we want to change these steps? Do we want to link the build options?
There was a problem hiding this comment.
Based on your needs, pick Cloud Build or Docker and include mostly bare steps here, linking to that page for more context/options?
There was a problem hiding this comment.
E.g., to keep the current instructions, add gcloud auth configure-docker.
There was a problem hiding this comment.
I've added the configure docker command.
Co-Authored-By: Adam Ross <adamross@google.com>
There was a problem hiding this comment.
@grayside Thanks for the review. Can you please take a look?
So long as there is no inaccurate information, I think this PR would be a good addition. If there are extra details that you know of that we could add right now, then please suggest them.
docs/docker.md
Outdated
|
|
||
| ## Deploy a Container | ||
|
|
||
| You can deploy your containerized function to Cloud Run or any Knative-based environment by following the [Cloud Run quickstart](https://cloud.google.com/run/docs/quickstarts/build-and-deploy). |
There was a problem hiding this comment.
What would you like me to say instead of Cloud Run?
Does Cloud Run not include Cloud Run on GKE?
Can you suggest a change?
|
|
||
| ```sh | ||
| docker build -t gcr.io/$GOOGLE_CLOUD_PROJECT/helloworld . | ||
| docker push gcr.io/$GOOGLE_CLOUD_PROJECT/helloworld |
There was a problem hiding this comment.
How do we want to change these steps? Do we want to link the build options?
|
I've updated the doc based on your review comments. Please look! |
Modifies PR to add instructions on how to deploy the FF to Cloud Run:
See #28
R: @grayside