fix: new errors in conformance tests #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there are probably two issues that need to be corrected in the cloud event conversion logic:
|
bshaffer
changed the title
dwsupplee
suggested changes
Jul 13, 2021
src/LegacyEventMapper.php
Outdated
| } | ||
| $location = 'us-central1'; | ||
| if ($domain !== 'firebaseio.com') { | ||
| preg_match('#^([\w-]+)\.firebasedatabase\.app$#', $domain, $locationMatches); |
There was a problem hiding this comment.
We are actually more lenient than this in other languages as we aren't sure that firebasedatabase.app will be the only domain possible. You can basically match everything up to the first dot.
We weakened the regex in the Ruby FF after the original PR I pointed you to
There was a problem hiding this comment.
@matthewrobertson done in 42ae03d
Co-authored-by: David Supplee <dwsupplee@gmail.com>
Co-authored-by: David Supplee <dwsupplee@gmail.com>
…m/functions-framework-php into fix-conformance-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.