Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc line linking #2025

Merged
merged 6 commits into from
Jul 29, 2016
Merged

Conversation

daspecster
Copy link
Contributor

Fixes #2024 and adds Error Reporting module.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 26, 2016

return source_path[1:]
return source_path

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@daspecster
Copy link
Contributor Author

@tseaver there we go. LMKWYT!

import pdoc
from parinx.parser import parse_docstring
from parinx.errors import MethodParsingException

from verify_included_modules import get_public_modules

ABSOLUTE_LIBRARY_PATH = '/'.join(os.path.abspath(gcloud.__file__)
.split('/')[:-2])


This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

if 'gcloud-python' in source:
source_path = source.split('gcloud-python')[1]
if ABSOLUTE_LIBRARY_PATH in source:
source_path = source.replace(ABSOLUTE_LIBRARY_PATH, '')

This comment was marked as spam.

This comment was marked as spam.

@tseaver
Copy link
Contributor

tseaver commented Jul 28, 2016

The test fix is my bad: I introduced the test failure while merging / fixing up #2029. I restarted Travis after pushing my fix.

@tseaver
Copy link
Contributor

tseaver commented Jul 28, 2016

LGTM

@daspecster daspecster merged commit c0e4e37 into googleapis:master Jul 29, 2016
@daspecster daspecster deleted the fix-doc-line-linking branch July 29, 2016 13:37
This was referenced Aug 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants