Add recursive to server #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rootRepository` is a arg to the function and a string that has hostname and path. Catalog() returns a slice of repositories, making the HasPrefix check never work. ref: GoogleCloudPlatform#38
I think the `deleteOne` is probably the best place for this, this lets all the code paths execute making it "accurate". ref: GoogleCloudPlatform#34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #41 but it also has #39 #38 in it as well, there wasn't a great way to do this and test it without the other two fixes. So it could be all done in this PR, I think I'll have to clean up the git history a bit depending on what you're interested in accepting.