New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running all the integration test with --only-dir mounting #1100
Merged
Tulsishah
merged 55 commits into
GoogleCloudPlatform:master
from
Tulsishah:running_integration_test_with_only_dir_mounting
May 23, 2023
Merged
Running all the integration test with --only-dir mounting #1100
Tulsishah
merged 55 commits into
GoogleCloudPlatform:master
from
Tulsishah:running_integration_test_with_only_dir_mounting
May 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tulsishah
changed the title
[Don't Review] Running integration test with only dir mounting
Running all the integration test with --only-dir mounting
May 9, 2023
sethiay
reviewed
May 10, 2023
sethiay
reviewed
May 16, 2023
tools/integration_tests/util/only_dir_mounting/only_dir_mounting.go
Outdated
Show resolved
Hide resolved
tools/integration_tests/util/static_mounting/static_mounting.go
Outdated
Show resolved
Hide resolved
sethiay
reviewed
May 18, 2023
tools/integration_tests/util/mounting/static_mounting/static_mounting.go
Outdated
Show resolved
Hide resolved
sethiay
reviewed
May 19, 2023
…st_with_only_dir_mounting
sethiay
approved these changes
May 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also get it reviewed from Prince.
raj-prince
reviewed
May 22, 2023
raj-prince
reviewed
May 22, 2023
raj-prince
reviewed
May 22, 2023
raj-prince
reviewed
May 22, 2023
raj-prince
requested changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please incorporate.
raj-prince
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be pull request template
Description
Added only_dir_mounting and static_mounting directories to able to mount the bucket both ways.
To run the tests with these mounting, we can call them by calling that package. RunTest function.
added timeout 60m as with default timeout(10m) it is calling SIGKILL in between for operations tests.
Link to the issue in case of a bug fix.
Testing details