Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running all the integration test with --only-dir mounting #1100

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented May 9, 2023

This will be pull request template

Description

Added only_dir_mounting and static_mounting directories to able to mount the bucket both ways.
To run the tests with these mounting, we can call them by calling that package. RunTest function.

added timeout 60m as with default timeout(10m) it is calling SIGKILL in between for operations tests.

Link to the issue in case of a bug fix.

Testing details

  1. Manual - All the integration tests are working fine for both the flags testBucket and mountedDirectoy.
  2. Unit tests - N/A
  3. Integration tests- All the integration tests are working fine together

@Tulsishah Tulsishah changed the title [Don't Review] Running integration test with only dir mounting Running all the integration test with --only-dir mounting May 9, 2023
@Tulsishah Tulsishah requested a review from sethiay May 17, 2023 03:13
@Tulsishah Tulsishah requested a review from sethiay May 19, 2023 08:44
@Tulsishah Tulsishah requested a review from sethiay May 19, 2023 09:24
Copy link
Collaborator

@sethiay sethiay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also get it reviewed from Prince.

Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please incorporate.

@Tulsishah Tulsishah requested a review from raj-prince May 22, 2023 04:50
@Tulsishah Tulsishah merged commit 9438a11 into GoogleCloudPlatform:master May 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants