Fixed false error for implicit dir in rename and remove directory flow

[ashmeenkaur]

Description

While running rm -r command on an implicit directory, we were getting the following error:
rm: cannot remove 'implicitSubDirectory/': Input/output error

While running mv command on an implicit directory, we were getting the following error:
mv: cannot stat 'implicitDirectory/': No such file or directory

Cause: for implicit directory, the 0 byte directory backing object did not exist on gcsfuse but we were still making a deleteObject request in DeleteChildDir() method.

Link to the issue in case of a bug fix.

NA

Testing details

1. Manual - Manually tested recursive delete and rename flows.
   Details:

   • Recursive delete:
     Mount Command: go run ./ --implicit-dirs --debug_fuse --debug_gcs --foreground ashmeenbkt /tmp/testnew/

     ashmeen@ashmeen:/tmp/testnew$ tree
     .
     ├── explicitDir
     ├── implicitDirectory1
     │   ├── file1InImplicitDir1
     │   ├── file2InImplicitDir1
     │   └── implicitDirectoryNested
     │       └── fileInNestedImplDir
     └── implicitDirectory2
         └── file1InImplicitDir2
     
     5 directories, 4 files
     ashmeen@ashmeen:/tmp/testnew$ rm -r explicitDir/
     ashmeen@ashmeen:/tmp/testnew$ tree
     .
     ├── implicitDirectory1
     │   ├── file1InImplicitDir1
     │   ├── file2InImplicitDir1
     │   └── implicitDirectoryNested
     │       └── fileInNestedImplDir
     └── implicitDirectory2
         └── file1InImplicitDir2
     
     4 directories, 4 files
     ashmeen@ashmeen:/tmp/testnew$ rm -r implicitDirectory1/
     ashmeen@ashmeen:/tmp/testnew$ tree
     .
     └── implicitDirectory2
         └── file1InImplicitDir2
     
     2 directories, 1 file
     ashmeen@ashmeen:/tmp/testnew$ rm -r implicitDirectory2/
     ashmeen@ashmeen:/tmp/testnew$ tree
     .
     
     0 directories, 0 files
     ashmeen@ashmeen:/tmp/test$ tree
     .
     └── explicitDir
         └── implicitDirectory
             └── fileInImplicitDir1
     
     3 directories, 1 file
     ashmeen@ashmeen:/tmp/test$ rm -r explicitDir/
     ashmeen@ashmeen:/tmp/test$ tree
     .
     
     0 directories, 0 files
   
   

   • rename:
     Mount Command: go run ./ --implicit-dirs --debug_fuse --debug_gcs --foreground --rename-dir-limit=3 ashmeenbkt /tmp/testnew/

    ashmeen@ashmeen:/tmp/testnew$ tree
     .
     ├── explicitDir
     │   └── f1.txt
     ├── implicitDirectory1
     │   ├── file1InImplicitDir1
     │   ├── file2InImplicitDir1
     │   └── implicitDirectoryNested
     │       └── fileInNestedImplDir
     └── implicitDirectory2
         └── file1InImplicitDir2
     
     5 directories, 5 files
     ashmeen@ashmeen:/tmp/testnew$ mv explicitDir/ newExplitDir/
     ashmeen@ashmeen:/tmp/testnew$ tree
     .
     ├── implicitDirectory1
     │   ├── file1InImplicitDir1
     │   ├── file2InImplicitDir1
     │   └── implicitDirectoryNested
     │       └── fileInNestedImplDir
     ├── implicitDirectory2
     │   └── file1InImplicitDir2
     └── newExplitDir
         └── f1.txt
     
     5 directories, 5 files
     ashmeen@ashmeen:/tmp/testnew$ mv implicitDirectory1/ newDirectory1/
     ashmeen@ashmeen:/tmp/testnew$ tree
     .
     ├── implicitDirectory2
     │   └── file1InImplicitDir2
     ├── newDirectory1
     │   ├── file1InImplicitDir1
     │   ├── file2InImplicitDir1
     │   └── implicitDirectoryNested
     │       └── fileInNestedImplDir
     └── newExplitDir
         └── f1.txt
     
     5 directories, 5 files
     ashmeen@ashmeen:/tmp/testnew$ mv implicitDirectory2/ newDirectory1/newSubDirectory2/
     ashmeen@ashmeen:/tmp/testnew$ tree
     .
     ├── newDirectory1
     │   ├── file1InImplicitDir1
     │   ├── file2InImplicitDir1
     │   ├── implicitDirectoryNested
     │   │   └── fileInNestedImplDir
     │   └── newSubDirectory2
     │       └── file1InImplicitDir2
     └── newExplitDir
         └── f1.txt
     
     5 directories, 5 files
     ashmeen@ashmeen:/tmp/testnew$ mv newDirectory1/implicitDirectoryNested/ renamedNestedDirectory/
     ashmeen@ashmeen:/tmp/testnew$ tree
     .
     ├── newDirectory1
     │   ├── file1InImplicitDir1
     │   ├── file2InImplicitDir1
     │   └── newSubDirectory2
     │       └── file1InImplicitDir2
     ├── newExplitDir
     │   └── f1.txt
     └── renamedNestedDirectory
         └── fileInNestedImplDir
     
     5 directories, 5 files
   
     ashmeen@ashmeen:/tmp/test$ tree
     .
     └── explicitDir
         └── implicitDirectory
             └── fileInImplicitDir1
     
     3 directories, 1 file
     ashmeen@ashmeen:/tmp/test$ mv explicitDir/ newDir/
     ashmeen@ashmeen:/tmp/test$ tree
     .
     └── newDir
         └── implicitDirectory
             └── fileInImplicitDir1
   
   
   

2. Unit tests - Added unit tests.

3. Integration tests - Ran all existing integration tests.

[sethiay]

Minor comment.
Please add details of manual testing in the description - mount command, test directory structure, command run and output.

[Tulsishah]

Please check all the flows. (List, Create, Delete, Compose, Stat, Update, Copy) to confirm nothing breaks.

[vadlakondaswetha]

also add manual testing details around implicitDir inside explicitDir and what happens when you try to delete/rename explicitDir.

[sethiay]

Couple of things:

1. Manually test and add in description about delete and rename flows where you create explicitDir inside implicitDir. Also test rmdir
2. Add execute-perf-tests to this PR which will run e2e tests and perf tests(which will indirectly cover read and write flows)

[sethiay]

Please add unit tests for rename also.

Added the requested changes in a separate file.

[vadlakondaswetha]

minor formatting comments. LGTM