Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read directory and unlink local file integration test #1386

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Read directory and unlink local file integration test #1386

merged 3 commits into from
Sep 25, 2023

Conversation

ashmeenkaur
Copy link
Collaborator

@ashmeenkaur ashmeenkaur commented Sep 19, 2023 •
edited

Description

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual -
  • Ran the following commands for test bucket tests
GODEBUG=asyncpreemptoff=1 go test ./tools/integration_tests/local_file/...  -p 1 --integrationTest -v --testbucket=$TEST_BUCKET_NAME

GODEBUG=asyncpreemptoff=1 go test ./tools/integration_tests/local_file/...  -p 1 --integrationTest -v --testbucket=$TEST_BUCKET_NAME --testInstalledPackage
  • Ran the following commands for mounted directory tests
# package local_file
# Run test with static mounting. (flags: --implicit-dirs=true)
gcsfuse --implicit-dirs=true --rename-dir-limit=3 $TEST_BUCKET_NAME $MOUNT_DIR
GODEBUG=asyncpreemptoff=1 go test ./tools/integration_tests/local_file/... -p 1 --integrationTest -v --mountedDirectory=$MOUNT_DIR --testbucket=$TEST_BUCKET_NAME
sudo umount $MOUNT_DIR

# Run test with static mounting. (flags: --implicit-dirs=false)
gcsfuse --implicit-dirs=false --rename-dir-limit=3 $TEST_BUCKET_NAME $MOUNT_DIR
GODEBUG=asyncpreemptoff=1 go test ./tools/integration_tests/local_file/... -p 1 --integrationTest -v --mountedDirectory=$MOUNT_DIR --testbucket=$TEST_BUCKET_NAME
sudo umount $MOUNT_DIR
  1. Unit tests - NA
  2. Integration tests - NA

@ashmeenkaur ashmeenkaur changed the title [ready for review] Read directory and unlink local file integration test [draft] Read directory and unlink local file integration test Sep 20, 2023
@ashmeenkaur ashmeenkaur force-pushed the rename_removeDir_local_file_test branch from ede4057 to b243d16 Compare September 21, 2023 09:22
@ashmeenkaur ashmeenkaur force-pushed the rename_removeDir_local_file_test branch 2 times, most recently from b5bd6d7 to 6e5b317 Compare September 22, 2023 03:47
@ashmeenkaur ashmeenkaur added the execute-integration-tests Run only integration tests label Sep 22, 2023
@ashmeenkaur ashmeenkaur changed the base branch from rename_removeDir_local_file_test to master September 22, 2023 04:06
@ashmeenkaur ashmeenkaur changed the title [draft] Read directory and unlink local file integration test Read directory and unlink local file integration test Sep 22, 2023
@ashmeenkaur ashmeenkaur merged commit da79b38 into master Sep 25, 2023
8 checks passed
@ashmeenkaur ashmeenkaur deleted the readDir_unlink_local_file_test branch September 26, 2023 07:00
gargnitingoogle pushed a commit that referenced this pull request Oct 4, 2023
@ashmeenkaur @gargnitingoogle
Read directory and unlink local file integration test (#1386)
c63028d 
* integration tests to verify readDir and unlink operations on local file

rebase changes

* rebase changes

* Empty-Commit
gargnitingoogle pushed a commit that referenced this pull request Oct 30, 2023
@ashmeenkaur @gargnitingoogle
Read directory and unlink local file integration test (#1386)
bd0903b 
* integration tests to verify readDir and unlink operations on local file

rebase changes

* rebase changes

* Empty-Commit
gargnitingoogle pushed a commit that referenced this pull request Oct 31, 2023
@ashmeenkaur @gargnitingoogle
Read directory and unlink local file integration test (#1386)
a295b31 
* integration tests to verify readDir and unlink operations on local file

rebase changes

* rebase changes

* Empty-Commit
gargnitingoogle pushed a commit that referenced this pull request Nov 1, 2023
@ashmeenkaur @gargnitingoogle
Read directory and unlink local file integration test (#1386)
c5ad0bd 
* integration tests to verify readDir and unlink operations on local file

rebase changes

* rebase changes

* Empty-Commit
@ashmeenkaur ashmeenkaur added remove-0-byte-file-changes and removed execute-integration-tests Run only integration tests labels Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadlakondaswetha vadlakondaswetha vadlakondaswetha approved these changes

@sethiay sethiay Awaiting requested review from sethiay

@raj-prince raj-prince Awaiting requested review from raj-prince

Assignees
No one assigned
Labels
remove-0-byte-file-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashmeenkaur @vadlakondaswetha