Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove chmod calls for running scripts #1489

Merged
merged 2 commits into from Nov 10, 2023
Merged

Remove chmod calls for running scripts #1489

merged 2 commits into from Nov 10, 2023

Conversation

gargnitingoogle
Copy link
Collaborator

Description

Remove chmod calls for running scripts

As in the previous commit, we now have
exec-mode set on all script files, and thus
chmod for runningi them is not needed anymore.

This is on top of Add exec-mode to script files .

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - Ran as presubmit

@gargnitingoogle gargnitingoogle force-pushed the gargnitin-fix-script-git-checkout-error branch from a03fd18 to 7dd8705 Compare November 1, 2023 10:59
@gargnitingoogle gargnitingoogle force-pushed the gargnitin-fix-script-git-checkout-error-2 branch from 93f44c9 to 893ff4e Compare November 1, 2023 10:59
@gargnitingoogle gargnitingoogle mentioned this pull request Nov 1, 2023
Merged
@gargnitingoogle gargnitingoogle added execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests labels Nov 1, 2023
@gargnitingoogle gargnitingoogle force-pushed the gargnitin-fix-script-git-checkout-error branch from 7dd8705 to 704056e Compare November 1, 2023 12:14
@gargnitingoogle gargnitingoogle force-pushed the gargnitin-fix-script-git-checkout-error-2 branch from 893ff4e to 435acac Compare November 1, 2023 12:17
@gargnitingoogle gargnitingoogle force-pushed the gargnitin-fix-script-git-checkout-error branch from 704056e to 65de916 Compare November 2, 2023 05:11
@gargnitingoogle gargnitingoogle force-pushed the gargnitin-fix-script-git-checkout-error-2 branch from 435acac to de6174a Compare November 2, 2023 05:12
@gargnitingoogle gargnitingoogle changed the base branch from gargnitin-fix-script-git-checkout-error to master November 2, 2023 15:21
@gargnitingoogle gargnitingoogle removed the execute-integration-tests Run only integration tests label Nov 2, 2023
@gargnitingoogle gargnitingoogle force-pushed the gargnitin-fix-script-git-checkout-error-2 branch 3 times, most recently from 4466075 to 7243fab Compare November 10, 2023 08:03
@gargnitingoogle
Copy link
Collaborator Author

gargnitingoogle commented Nov 10, 2023 •
edited

This PR will need a rebase probably once its dependency #1486 is merged into master.

@gargnitingoogle
Remove chmod calls for running scripts
8b4a715 
As in the previous commit, we now have
exec-mode set on all script files, and thus
chmod for runningi them is not needed anymore.
@gargnitingoogle
Remove chmod calls for running scripts
bc06355 
As in the previous commit, we now have
exec-mode set on all script files, and thus
chmod for runnini them is not needed anymore.
@gargnitingoogle gargnitingoogle force-pushed the gargnitin-fix-script-git-checkout-error-2 branch from 527877d to bc06355 Compare November 10, 2023 08:13
@gargnitingoogle
Copy link
Collaborator Author

This PR will need a rebase probably once its dependency #1486 is merged into master.

This is done.

@gargnitingoogle
Copy link
Collaborator Author

@ashmeenkaur @raj-prince the fio perf presubmit tests passed on this PR.

Build log

+--------+------------+--------------+------------+--------------+--------------+
| Branch | File Size | Read BW | Write BW | RandRead BW | RandWrite BW |
+--------+------------+--------------+------------+--------------+--------------+
| Master | 0.25MiB | 459.0MiB/s | 1.19MiB/s | 34.56MiB/s | 1.13MiB/s |
| PR | 0.25MiB | 485.99MiB/s | 1.05MiB/s | 35.17MiB/s | 0.96MiB/s |
| | | | | | |
| | | | | | |
| Master | 48.828MiB | 4401.07MiB/s | 76.13MiB/s | 1157.14MiB/s | 79.57MiB/s |
| PR | 48.828MiB | 4370.97MiB/s | 75.01MiB/s | 1136.26MiB/s | 72.41MiB/s |
| | | | | | |
| | | | | | |
| Master | 976.562MiB | 4501.96MiB/s | 33.29MiB/s | 514.7MiB/s | 32.11MiB/s |
| PR | 976.562MiB | 4054.88MiB/s | 28.8MiB/s | 681.05MiB/s | 23.41MiB/s |
| | | | | | |
| | | | | | |
+--------+------------+--------------+------------+--------------+--------------+

@gargnitingoogle gargnitingoogle merged commit 4e89ab6 into master Nov 10, 2023
8 checks passed
@gargnitingoogle gargnitingoogle deleted the gargnitin-fix-script-git-checkout-error-2 branch November 10, 2023 11:17
gargnitingoogle added a commit that referenced this pull request Nov 28, 2023
@gargnitingoogle
Remove chmod calls for running scripts (#1489)
3003b5a 
* Remove chmod calls for running scripts

As in the previous commit, we now have
exec-mode set on all script files, and thus
chmod for running them is not needed anymore.
gargnitingoogle added a commit that referenced this pull request Nov 29, 2023
@gargnitingoogle
Remove chmod calls for running scripts (#1489)
915cfe5 
* Remove chmod calls for running scripts

As in the previous commit, we now have
exec-mode set on all script files, and thus
chmod for running them is not needed anymore.
gargnitingoogle added a commit that referenced this pull request Nov 29, 2023
@gargnitingoogle
Remove chmod calls for running scripts (#1489)
c714645 
* Remove chmod calls for running scripts

As in the previous commit, we now have
exec-mode set on all script files, and thus
chmod for running them is not needed anymore.
@p-linnane p-linnane mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raj-prince raj-prince raj-prince approved these changes

@ashmeenkaur ashmeenkaur ashmeenkaur approved these changes

@sethiay sethiay Awaiting requested review from sethiay

@vadlakondaswetha vadlakondaswetha Awaiting requested review from vadlakondaswetha

Assignees
No one assigned
Labels
execute-perf-test Execute performance test in PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gargnitingoogle @raj-prince @ashmeenkaur