Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pr perf test #1490

Merged
merged 4 commits into from Nov 2, 2023
Merged

Fix pr perf test #1490

merged 4 commits into from Nov 2, 2023

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Nov 1, 2023 •
edited

Description

Previously failing because of

fetching results..
Traceback (most recent call last):
  File "./perfmetrics/scripts/presubmit/fetch_results.py", line 18, in <module>
    from fio.fio_metrics import FioMetrics
  File "/tmpfs/src/github/gcsfuse/./perfmetrics/scripts/fio/fio_metrics.py", line 36, in <module>
    from bigquery import experiments_gcsfuse_bq
  File "/tmpfs/src/github/gcsfuse/./perfmetrics/scripts/bigquery/experiments_gcsfuse_bq.py", line 24, in <module>
    from google.cloud import bigquery
ImportError: cannot import name 'bigquery' from 'google.cloud' (unknown location)

Adding install big query module in perf test build script.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - tested on kokoro.
  2. Unit tests - NA
  3. Integration tests - NA

@Tulsishah Tulsishah added the execute-perf-test Execute performance test in PR label Nov 1, 2023
@Tulsishah Tulsishah force-pushed the fix_pr_perf_test branch 4 times, most recently from e00c023 to 19d733e Compare November 1, 2023 14:57
@Tulsishah Tulsishah removed the execute-perf-test Execute performance test in PR label Nov 1, 2023
@Tulsishah Tulsishah changed the title [Don't Review] Fix pf perf test Fix pr perf test Nov 1, 2023
@Tulsishah Tulsishah merged commit 5f8369a into master Nov 2, 2023
8 checks passed
gargnitingoogle pushed a commit that referenced this pull request Nov 28, 2023
@Tulsishah @gargnitingoogle
Fix pr perf test (#1490)
dc6871d 
* test fix

* test fix

* test fix

* remove rest changes
gargnitingoogle pushed a commit that referenced this pull request Nov 29, 2023
@Tulsishah @gargnitingoogle
Fix pr perf test (#1490)
b0c5bb2 
* test fix

* test fix

* test fix

* remove rest changes
gargnitingoogle pushed a commit that referenced this pull request Nov 29, 2023
@Tulsishah @gargnitingoogle
Fix pr perf test (#1490)
de78d8b 
* test fix

* test fix

* test fix

* remove rest changes
@p-linnane p-linnane mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raj-prince raj-prince raj-prince approved these changes

@sethiay sethiay Awaiting requested review from sethiay

@vadlakondaswetha vadlakondaswetha Awaiting requested review from vadlakondaswetha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tulsishah @raj-prince