Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade go storage pkg from 1.31.0 to 1.34.1 #1491

Merged
merged 6 commits into from Nov 6, 2023
Merged

Upgrade go storage pkg from 1.31.0 to 1.34.1 #1491

merged 6 commits into from Nov 6, 2023

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Nov 2, 2023 •
edited

Description

Upgrade go storage pkg from 1.31.0 to 1.34.1 with go get cloud.google.com/go/storage@latest.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Pr perf tests and e2e tests.
  2. Unit tests - NA
  3. Integration tests - NA

@Tulsishah Tulsishah added the execute-perf-test Execute performance test in PR label Nov 2, 2023
@Tulsishah Tulsishah mentioned this pull request Nov 2, 2023
Closed
@Tulsishah Tulsishah removed the execute-perf-test Execute performance test in PR label Nov 2, 2023
Tulsishah
Tulsishah commented Nov 2, 2023
View reviewed changes
Copy link
Collaborator Author

@Tulsishah Tulsishah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

84jemAsgouePHMP

Tulsishah
Tulsishah commented Nov 2, 2023
View reviewed changes
Copy link
Collaborator Author

@Tulsishah Tulsishah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raj-prince PTAL

@raj-prince
Copy link
Collaborator

I can see a major gap in the Read bandwidth for the 976.56MiB file. Could you please re-run the test?

Also, please include the go-storage version (From to To) in the PR title and description.

@Tulsishah Tulsishah added the execute-perf-test Execute performance test in PR label Nov 6, 2023
@Tulsishah Tulsishah added the execute-integration-tests Run only integration tests label Nov 6, 2023
Tulsishah
Tulsishah commented Nov 6, 2023
View reviewed changes
Copy link
Collaborator Author

@Tulsishah Tulsishah left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iRrsrvbotVbBBSG

@raj-prince PTAL

@Tulsishah Tulsishah removed execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests labels Nov 6, 2023
raj-prince
raj-prince approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the go storage version (From to To) in the PR title also.

@Tulsishah Tulsishah changed the title Upgrade go storage pkg Upgrade go storage pkg from 1.31.0 to 1.34.1 Nov 6, 2023
@Tulsishah
Copy link
Collaborator Author

Please add the go storage version (From to To) in the PR title also.

Done

@Tulsishah Tulsishah merged commit 7a10d39 into dec_2023_release Nov 6, 2023
8 checks passed
This was referenced Nov 6, 2023
Closed
Closed
@Tulsishah Tulsishah mentioned this pull request Nov 21, 2023
Closed
gargnitingoogle pushed a commit that referenced this pull request Nov 28, 2023
@Tulsishah @gargnitingoogle
Upgrade go storage pkg from 1.31.0 to 1.34.1 (#1491)
76a15f6 
* upgrading go storage pkg

* upgrading go storage pkg

* remove test changes

* test changes

* test changes

* remove test changes
gargnitingoogle pushed a commit that referenced this pull request Nov 28, 2023
@Tulsishah @gargnitingoogle
Upgrade go storage pkg from 1.31.0 to 1.34.1 (#1491)
cddf31a 
* upgrading go storage pkg

* upgrading go storage pkg

* remove test changes

* test changes

* test changes

* remove test changes
gargnitingoogle pushed a commit that referenced this pull request Nov 28, 2023
@Tulsishah @gargnitingoogle
Upgrade go storage pkg from 1.31.0 to 1.34.1 (#1491)
b1ccf7d 
* upgrading go storage pkg

* upgrading go storage pkg

* remove test changes

* test changes

* test changes

* remove test changes
gargnitingoogle pushed a commit that referenced this pull request Nov 29, 2023
@Tulsishah @gargnitingoogle
Upgrade go storage pkg from 1.31.0 to 1.34.1 (#1491)
3f3a4f7 
* upgrading go storage pkg

* upgrading go storage pkg

* remove test changes

* test changes

* test changes

* remove test changes
raj-prince pushed a commit that referenced this pull request Nov 29, 2023
@Tulsishah @raj-prince
Upgrade go storage pkg from 1.31.0 to 1.34.1 (#1491)
70d36ff 
* upgrading go storage pkg

* upgrading go storage pkg

* remove test changes

* test changes

* test changes

* remove test changes
@p-linnane p-linnane mentioned this pull request Dec 18, 2023
Merged
gargnitingoogle pushed a commit that referenced this pull request Jan 4, 2024
@Tulsishah @gargnitingoogle
Upgrade go storage pkg from 1.31.0 to 1.34.1 (#1491)
dca768c 
* upgrading go storage pkg

* upgrading go storage pkg

* remove test changes

* test changes

* test changes

* remove test changes
ashmeenkaur pushed a commit that referenced this pull request Jan 9, 2024
@Tulsishah @ashmeenkaur
Upgrade go storage pkg from 1.31.0 to 1.34.1 (#1491)
c765b19 
* upgrading go storage pkg

* upgrading go storage pkg

* remove test changes

* test changes

* test changes

* remove test changes
ashmeenkaur pushed a commit that referenced this pull request Jan 10, 2024
@Tulsishah @ashmeenkaur
Upgrade go storage pkg from 1.31.0 to 1.34.1 (#1491)
eb49f93 
* upgrading go storage pkg

* upgrading go storage pkg

* remove test changes

* test changes

* test changes

* remove test changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raj-prince raj-prince raj-prince approved these changes

@sethiay sethiay Awaiting requested review from sethiay sethiay is a code owner

@vadlakondaswetha vadlakondaswetha Awaiting requested review from vadlakondaswetha vadlakondaswetha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tulsishah @raj-prince