Fix experimental periodic perf test #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tulsishah
requested review from
sethiay,
vadlakondaswetha and
raj-prince
as code owners
Tulsishah
force-pushed
the
fix_periodic_perf_test
branch
from
6adea5e
to
3bdb9e4
Compare
Tulsishah
force-pushed
the
fix_periodic_perf_test
branch
2 times, most recently
from
5db3025
to
449689c
Compare
Tulsishah
force-pushed
the
fix_periodic_perf_test
branch
from
449689c
to
2d19cba
Compare
Tulsishah
commented
Nov 11, 2023
raj-prince
reviewed
Nov 14, 2023
raj-prince
reviewed
Nov 14, 2023
perfmetrics/scripts/continuous_test/gcp_ubuntu/periodic_experiments/build.sh
Outdated
Show resolved
Hide resolved
Tulsishah
force-pushed
the
fix_periodic_perf_test
branch
from
51e09ba
to
4fa812e
Compare
raj-prince
approved these changes
Nov 14, 2023
gargnitingoogle
pushed a commit
that referenced
this pull request
Nov 28, 2023
* adding testing statements * fix periodic perf test * adding branch name echo * pass bucket nmea as argument * small ifx
gargnitingoogle
pushed a commit
that referenced
this pull request
Nov 29, 2023
* adding testing statements * fix periodic perf test * adding branch name echo * pass bucket nmea as argument * small ifx
gargnitingoogle
pushed a commit
that referenced
this pull request
Nov 29, 2023
* adding testing statements * fix periodic perf test * adding branch name echo * pass bucket nmea as argument * small ifx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is failing because writes are happening on the same bucket with the same files parallelly with four experiments.
Link to the issue in case of a bug fix.
NA
Testing details