Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add configs for log rotation #1505

Merged
merged 3 commits into from Nov 17, 2023
Merged

add configs for log rotation #1505

merged 3 commits into from Nov 17, 2023

Conversation

ashmeenkaur
Copy link
Collaborator

Description

Added the following configs for log rotation.

  1. max-file-size-mb: specifies the maximum size in megabytes that a log file
    can reach before it is rotated. The default value is 512 megabytes.
  2. file-count: determines the maximum number of log files to retain after they
    have been rotated. The default value is 10.
  3. compress: indicates whether the rotated log files should be compressed
    using gzip. The default value is False.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - added
  3. Integration tests - NA

@ashmeenkaur ashmeenkaur marked this pull request as ready for review November 16, 2023 08:43
raj-prince
raj-prince requested changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Few minor comments.

internal/config/yaml_parser_test.go Outdated Show resolved Hide resolved
internal/config/mount_config.go Show resolved Hide resolved
internal/config/yaml_parser.go Outdated Show resolved Hide resolved
internal/config/testdata/invalid_log_rotate_config_1.yaml Show resolved Hide resolved
internal/config/yaml_parser.go Outdated Show resolved Hide resolved
internal/config/yaml_parser_test.go Outdated Show resolved Hide resolved
@ashmeenkaur ashmeenkaur merged commit 18674ab into dec_2023_release Nov 17, 2023
4 checks passed
gargnitingoogle pushed a commit that referenced this pull request Nov 28, 2023
@ashmeenkaur @gargnitingoogle
add configs for log rotation (#1505)
b452779 
* add configs for log rotation

* review comments

* review comments
gargnitingoogle pushed a commit that referenced this pull request Nov 28, 2023
@ashmeenkaur @gargnitingoogle
add configs for log rotation (#1505)
03d7694 
* add configs for log rotation

* review comments

* review comments
gargnitingoogle pushed a commit that referenced this pull request Nov 28, 2023
@ashmeenkaur @gargnitingoogle
add configs for log rotation (#1505)
a4cb11f 
* add configs for log rotation

* review comments

* review comments
gargnitingoogle pushed a commit that referenced this pull request Nov 29, 2023
@ashmeenkaur @gargnitingoogle
add configs for log rotation (#1505)
c66d0ae 
* add configs for log rotation

* review comments

* review comments
raj-prince pushed a commit that referenced this pull request Nov 29, 2023
@ashmeenkaur @raj-prince
add configs for log rotation (#1505)
baeb37f 
* add configs for log rotation

* review comments

* review comments
@ashmeenkaur ashmeenkaur deleted the log_rotation_configs branch December 4, 2023 05:57
@p-linnane p-linnane mentioned this pull request Dec 18, 2023
Merged
gargnitingoogle pushed a commit that referenced this pull request Jan 4, 2024
@ashmeenkaur @gargnitingoogle
add configs for log rotation (#1505)
3c3c910 
* add configs for log rotation

* review comments

* review comments
ashmeenkaur added a commit that referenced this pull request Jan 9, 2024
@ashmeenkaur
add configs for log rotation (#1505)
9dba517 
* add configs for log rotation

* review comments

* review comments
ashmeenkaur added a commit that referenced this pull request Jan 10, 2024
@ashmeenkaur
add configs for log rotation (#1505)
c348ec9 
* add configs for log rotation

* review comments

* review comments
gargnitingoogle pushed a commit that referenced this pull request Feb 19, 2024
@ashmeenkaur @gargnitingoogle
add configs for log rotation (#1505)
8b00855 
* add configs for log rotation

* review comments

* review comments
gargnitingoogle pushed a commit that referenced this pull request Feb 20, 2024
@ashmeenkaur @gargnitingoogle
add configs for log rotation (#1505)
2c6df18 
* add configs for log rotation

* review comments

* review comments
gargnitingoogle pushed a commit that referenced this pull request Feb 22, 2024
@ashmeenkaur @gargnitingoogle
add configs for log rotation (#1505)
a1caa10 
* add configs for log rotation

* review comments

* review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raj-prince raj-prince raj-prince approved these changes

@sethiay sethiay Awaiting requested review from sethiay sethiay is a code owner

@vadlakondaswetha vadlakondaswetha Awaiting requested review from vadlakondaswetha vadlakondaswetha is a code owner

Assignees
No one assigned
Labels
logging improvements - log rotation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashmeenkaur @raj-prince