Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pytorch 2 support #1513

Merged
merged 18 commits into from Nov 27, 2023
Merged

Pytorch 2 support #1513

merged 18 commits into from Nov 27, 2023

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Nov 21, 2023 •
edited

Description

Made structure

  • ml_tests/pytorch
  • ml_tests/pytorch/v1_12/dino
  • ml_tests/pytorch/v2/dino

Pytorch2 will create g2-standard machine. Put if condition for the same.

  • Driver version for NVIDIA L4 machine is 525.60.13 - made const for the same
  • pytorch2.0 docker image has python3.10 installed - made const for the same
  • Some refactoring in file names. (setup_container.sh --> run_model.sh)
  • Two docker file - one for pytorch1.12 other for pytorch2.0.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Tested whole setup locally.
  2. Unit tests - NA
  3. Integration tests - NA

@Tulsishah Tulsishah force-pushed the pytorch_2_support branch 2 times, most recently from 0f10ba3 to c88b849 Compare November 21, 2023 10:14
@Tulsishah Tulsishah changed the title [Don't Review] Pytorch 2 support Pytorch 2 support Nov 23, 2023
raj-prince
raj-prince requested changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor refactoring.

@Tulsishah Tulsishah merged commit 3a66e45 into master Nov 27, 2023
8 checks passed
Tulsishah added a commit that referenced this pull request Nov 27, 2023
@Tulsishah
Pytorch 2 support (#1513)
65ddfc8 
* adding testing statements

* adding scripts to run model with pytorch2.0

* small fixes and adding licence

* dino model change to support pytorch 2.0

* dino model change to support pytorch 2.0

* small fix

* refactoring

* refactoring

* refactoring

* small fix

* small fix

* adding comments

* fixing comments

* fixing comments

* fixing comments

* removing python version

* removing python version

* removing python version
gargnitingoogle pushed a commit that referenced this pull request Nov 28, 2023
@Tulsishah @gargnitingoogle
Pytorch 2 support (#1513)
e4f379b 
* adding testing statements

* adding scripts to run model with pytorch2.0

* small fixes and adding licence

* dino model change to support pytorch 2.0

* dino model change to support pytorch 2.0

* small fix

* refactoring

* refactoring

* refactoring

* small fix

* small fix

* adding comments

* fixing comments

* fixing comments

* fixing comments

* removing python version

* removing python version

* removing python version
gargnitingoogle pushed a commit that referenced this pull request Nov 29, 2023
@Tulsishah @gargnitingoogle
Pytorch 2 support (#1513)
7e7ad0b 
* adding testing statements

* adding scripts to run model with pytorch2.0

* small fixes and adding licence

* dino model change to support pytorch 2.0

* dino model change to support pytorch 2.0

* small fix

* refactoring

* refactoring

* refactoring

* small fix

* small fix

* adding comments

* fixing comments

* fixing comments

* fixing comments

* removing python version

* removing python version

* removing python version
Tulsishah added a commit that referenced this pull request Nov 29, 2023
@Tulsishah
Upgrading go version 1.21.3 to 1.21.4 (#1525)
759bdd1 
* upgrading go version

* upgrade go version

* Pytorch 2 support (#1513)

* adding testing statements

* adding scripts to run model with pytorch2.0

* small fixes and adding licence

* dino model change to support pytorch 2.0

* dino model change to support pytorch 2.0

* small fix

* refactoring

* refactoring

* refactoring

* small fix

* small fix

* adding comments

* fixing comments

* fixing comments

* fixing comments

* removing python version

* removing python version

* removing python version

* empty commit

* empty commit
gargnitingoogle pushed a commit that referenced this pull request Nov 29, 2023
@Tulsishah @gargnitingoogle
Pytorch 2 support (#1513)
e491040 
* adding testing statements

* adding scripts to run model with pytorch2.0

* small fixes and adding licence

* dino model change to support pytorch 2.0

* dino model change to support pytorch 2.0

* small fix

* refactoring

* refactoring

* refactoring

* small fix

* small fix

* adding comments

* fixing comments

* fixing comments

* fixing comments

* removing python version

* removing python version

* removing python version
@p-linnane p-linnane mentioned this pull request Dec 18, 2023
Merged
gargnitingoogle pushed a commit that referenced this pull request Jan 4, 2024
@Tulsishah @gargnitingoogle
Upgrading go version 1.21.3 to 1.21.4 (#1525)
715b475 
* upgrading go version

* upgrade go version

* Pytorch 2 support (#1513)

* adding testing statements

* adding scripts to run model with pytorch2.0

* small fixes and adding licence

* dino model change to support pytorch 2.0

* dino model change to support pytorch 2.0

* small fix

* refactoring

* refactoring

* refactoring

* small fix

* small fix

* adding comments

* fixing comments

* fixing comments

* fixing comments

* removing python version

* removing python version

* removing python version

* empty commit

* empty commit
ashmeenkaur pushed a commit that referenced this pull request Jan 9, 2024
@Tulsishah @ashmeenkaur
Upgrading go version 1.21.3 to 1.21.4 (#1525)
e56f21c 
* upgrading go version

* upgrade go version

* Pytorch 2 support (#1513)

* adding testing statements

* adding scripts to run model with pytorch2.0

* small fixes and adding licence

* dino model change to support pytorch 2.0

* dino model change to support pytorch 2.0

* small fix

* refactoring

* refactoring

* refactoring

* small fix

* small fix

* adding comments

* fixing comments

* fixing comments

* fixing comments

* removing python version

* removing python version

* removing python version

* empty commit

* empty commit
ashmeenkaur pushed a commit that referenced this pull request Jan 10, 2024
@Tulsishah @ashmeenkaur
Upgrading go version 1.21.3 to 1.21.4 (#1525)
ef37547 
* upgrading go version

* upgrade go version

* Pytorch 2 support (#1513)

* adding testing statements

* adding scripts to run model with pytorch2.0

* small fixes and adding licence

* dino model change to support pytorch 2.0

* dino model change to support pytorch 2.0

* small fix

* refactoring

* refactoring

* refactoring

* small fix

* small fix

* adding comments

* fixing comments

* fixing comments

* fixing comments

* removing python version

* removing python version

* removing python version

* empty commit

* empty commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raj-prince raj-prince raj-prince approved these changes

@sethiay sethiay Awaiting requested review from sethiay

@vadlakondaswetha vadlakondaswetha Awaiting requested review from vadlakondaswetha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tulsishah @raj-prince