Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log rotation script from gcsfuse long haul tests #1543

Merged
merged 2 commits into from Dec 11, 2023

Conversation

ashmeenkaur
Copy link
Collaborator

There is no need to explicitly rotate GCSFuse logs via script in GCSFuse long haul tests as log rotation can be done via configs following GCSFuse release v1.3.0.

Description

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Currently running long haul tests are doing log rotation by default.
  2. Unit tests - NA
  3. Integration tests - NA

@ashmeenkaur ashmeenkaur marked this pull request as ready for review December 11, 2023 05:35
@ashmeenkaur ashmeenkaur merged commit ba7e163 into master Dec 11, 2023
8 checks passed
@ashmeenkaur ashmeenkaur deleted the remove-old-log-rotation-from-long-haul-test branch December 13, 2023 08:57
gargnitingoogle pushed a commit that referenced this pull request Jan 4, 2024
* remove log rotation script from gcsfuse long haul tests as it is done by default

* review comment
ashmeenkaur added a commit that referenced this pull request Jan 9, 2024
* remove log rotation script from gcsfuse long haul tests as it is done by default

* review comment
ashmeenkaur added a commit that referenced this pull request Jan 10, 2024
* remove log rotation script from gcsfuse long haul tests as it is done by default

* review comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants