Lower freq of syncs in periodic-perf-tests #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for internal bug id 316284545 . Currently in the periodic perf tests, we fsync after each write (set through fsync=1) in all write tests. This poses two problems. 1. It underrates our write bandwidth as most of the runtime is spent in the sync calls and little in the actual write operation. 2. This causes frequent sync which result in frequent object generations on GCS, which is throttled by GCS. This change should address both these problems.
gargnitingoogle
requested review from
sethiay,
vadlakondaswetha and
raj-prince
as code owners
sethiay
reviewed
Dec 15, 2023
sethiay
approved these changes
Dec 20, 2023
gargnitingoogle
added a commit
that referenced
this pull request
Jan 4, 2024
This is for internal bug id 316284545 . Currently in the periodic perf tests, we fsync after each write (set through fsync=1) in all write tests. This poses two problems. 1. It underrates our write bandwidth as most of the runtime is spent in the sync calls and little in the actual write operation. 2. This causes frequent sync which result in frequent object generations on GCS, which is throttled by GCS. This change should address both these problems.
ashmeenkaur
pushed a commit
that referenced
this pull request
Jan 9, 2024
This is for internal bug id 316284545 . Currently in the periodic perf tests, we fsync after each write (set through fsync=1) in all write tests. This poses two problems. 1. It underrates our write bandwidth as most of the runtime is spent in the sync calls and little in the actual write operation. 2. This causes frequent sync which result in frequent object generations on GCS, which is throttled by GCS. This change should address both these problems.
ashmeenkaur
pushed a commit
that referenced
this pull request
Jan 10, 2024
This is for internal bug id 316284545 . Currently in the periodic perf tests, we fsync after each write (set through fsync=1) in all write tests. This poses two problems. 1. It underrates our write bandwidth as most of the runtime is spent in the sync calls and little in the actual write operation. 2. This causes frequent sync which result in frequent object generations on GCS, which is throttled by GCS. This change should address both these problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is for internal bug id 316284545 .
Currently in the periodic perf tests, we
fsync after each write (set through fsync=1)
in all write tests. This poses two problems.
little in the actual write operation.
throttled by GCS.
This change should address both these problems.
Link to the issue in case of a bug fix.
NA
Testing details