Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert and bump only direct dependencies #1671

Merged
merged 3 commits into from Jan 31, 2024

Conversation

ashmeenkaur
Copy link
Collaborator

@ashmeenkaur ashmeenkaur commented Jan 31, 2024

Description

This includes following dependabot PRs (upgrading only direct dependencies):

  1. Bump cloud.google.com/go/storage from 1.34.1 to 1.37.0 #1654
  2. Bump google.golang.org/api from 0.157.0 to 0.159.0 #1659
  3. Bump google.golang.org/api from 0.149.0 to 0.157.0 #1636
  4. Bump github.com/urfave/cli from 1.22.5 to 1.22.14 #1586
  5. Bump contrib.go.opencensus.io/exporter/stackdriver from 0.13.11 to 0.13.14 #1588

This PR also reverts:

  1. Bump dependencies Part 2 #1650
  2. Bump dependencies Part 1 #1630

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - Ran via kokoro
  4. Perf tests -
    5dPu9JpeQm4JX8A

@ashmeenkaur ashmeenkaur added execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests labels Jan 31, 2024
@ashmeenkaur ashmeenkaur changed the title Revert and fix dependabot prs Revert and bump only direct dependencies Jan 31, 2024
@ashmeenkaur ashmeenkaur marked this pull request as ready for review January 31, 2024 08:20
@raj-prince
Copy link
Collaborator

Changes looks good to me.

Just want to confirm about - PR#1650 and PR#1630.
Are we only reverting indirect changes? If yes, then please update the description.

@ashmeenkaur
Copy link
Collaborator Author

Changes looks good to me.

Just want to confirm about - PR#1650 and PR#1630. Are we only reverting indirect changes? If yes, then please update the description.

We have reverted those PRs since they had both direct and indirect dependencies. The last commit includes only direct dependencies that were raised by dependabot.

@raj-prince
Copy link
Collaborator

Got it, thanks!

@ashmeenkaur ashmeenkaur merged commit 1e3ce75 into master Jan 31, 2024
8 checks passed
@ashmeenkaur ashmeenkaur deleted the revert_and_fix_dependabot_prs branch January 31, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests execute-perf-test Execute performance test in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants