Enable or disable file cache via cache-dir #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethiay
requested review from
vadlakondaswetha and
raj-prince
as code owners
ashmeenkaur
reviewed
Feb 16, 2024
ashmeenkaur
previously approved these changes
Feb 16, 2024
raj-prince
previously approved these changes
Feb 16, 2024
raj-prince
approved these changes
Feb 16, 2024
gargnitingoogle
pushed a commit
that referenced
this pull request
Feb 19, 2024
gargnitingoogle
pushed a commit
that referenced
this pull request
Feb 20, 2024
gargnitingoogle
pushed a commit
that referenced
this pull request
Feb 22, 2024
ashmeenkaur
pushed a commit
that referenced
this pull request
Feb 26, 2024
ashmeenkaur
pushed a commit
that referenced
this pull request
Feb 27, 2024
ashmeenkaur
pushed a commit
that referenced
this pull request
Feb 27, 2024
sethiay
added
the
read-cache-implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable or disable file cache via cache-dir and not via max-size-mb. Also, make max-size-mb default as -1. Also did some refactoring to make sure util.go don't make any other internal package imports and we also don't go into cyclic dependency.
Link to the issue in case of a bug fix.
NA
Testing details