Upgrade to go 1.22.1 (with fix for dockerfiles) #1764

gargnitingoogle · 2024-03-04T19:13:50Z

Description

Reapply "Upgrade to golang 1.22 (Upgrade to golang 1.22 #1753)" (Revert "Upgrade to golang 1.22 (#1753)" #1766)
This reverts commit a63a46f.
Fixes dockerfiles which failed with go 1.22, because of go get error, by switching to git clone (in the docker container).
Upgrade to 1.22.1

Link to the issue in case of a bug fix.

NA

Testing details

Manual - Sanity testing
Unit tests - NA
Integration tests - Passed.
Perf tests

+--------+------------+--------------+------------+--------------+--------------+
| Branch | File Size  |   Read BW    |  Write BW  | RandRead BW  | RandWrite BW |
+--------+------------+--------------+------------+--------------+--------------+
| Master |  0.25MiB   | 536.37MiB/s  | 1.26MiB/s  |  77.95MiB/s  |  1.08MiB/s   |
|   PR   |  0.25MiB   | 518.86MiB/s  |  1.3MiB/s  |  70.12MiB/s  |  1.31MiB/s   |
|        |            |              |            |              |              |
| Master | 48.828MiB  | 4645.71MiB/s | 80.55MiB/s | 1238.05MiB/s |  79.37MiB/s  |
|   PR   | 48.828MiB  | 4477.76MiB/s | 79.18MiB/s | 1277.78MiB/s |  80.71MiB/s  |
|        |            |              |            |              |              |
| Master | 976.562MiB | 4406.04MiB/s | 33.37MiB/s | 477.44MiB/s  |  32.95MiB/s  |
|   PR   | 976.562MiB | 4423.47MiB/s | 33.91MiB/s | 608.93MiB/s  |  31.9MiB/s   |
|        |            |              |            |              |              |
+--------+------------+--------------+------------+--------------+--------------+

gargnitingoogle · 2024-03-06T09:03:48Z

Link to presubmit tests passing log: logs

gargnitingoogle · 2024-03-07T04:21:01Z

Marking as draft until I try out the switch to git clone from go get in the dockerfiles.

tools/containerize_gcsfuse_docker/Dockerfile

raj-prince

Changes look good to me, other than one confirmation comment.

Other than that, as we discussed offline.

We should sanity it by running it with louhi test-flow.
Also, should check the impact of these changes with GKE team.

gargnitingoogle · 2024-03-11T11:22:13Z

We should sanity it by running it with louhi test-flow.

Ran it once and build went through. I have given it another run after adding the --depth 1 flag, to reduce cloning time.

Also, should check the impact of these changes with GKE team.

Will check with @songjiaxun .

Reapply "Upgrade to golang 1.22 (#1753)" (#1766) This reverts commit a63a46f and fixes merge conflicts with golang 1.21.7 upgrade which went in earlier.

Does the following 1. Create a go module (go.mod) in a directory package_gcsfuse, to bypass the change in go get behaviour introduced in 1.17 and enforced in go 1.22. 2. Fix some paths and commands etc. accordingly in the dockerfile.

Fetch only the last commit state in docker files during git clone to reduce its runtime. This reduces the runtime of git clone dramatically.

gargnitingoogle · 2024-03-12T03:54:10Z

@raj-prince

We should sanity it by running it with louhi test-flow.

Ran it once and build went through. I have given it another run after adding the --depth 1 flag, to reduce cloning time.

I checked Louhi test-flow with --depth 1 and that worked too.

Also, should check the impact of these changes with GKE team.

Will check with @songjiaxun .

@songjiaxun shared over chat that "GKE Louhi pipeline and the testgrid uses tools/package_gcsfuse_docker/Dockerfile to build gcsfuse binary, so as long as the Dockerfile works, out pipeline should be fine.". So I think we're good there.

Also, I upgraded this PR to 1.22.1 (from 1.22) as @songjiaxun requested.

gargnitingoogle · 2024-03-12T07:00:05Z

@raj-prince please approve this. This has passed the integration and perf tests, and louhi-test workflow.

* Upgrade to golang 1.22 (without dockerfile fix) Reapply "Upgrade to golang 1.22 (#1753)" (#1766) This reverts commit a63a46f and fixes merge conflicts with golang 1.21.7 upgrade which went in earlier. * Fix containerize_gcsfuse/dockerfile for go 1.22 Does the following 1. Create a go module (go.mod) in a directory package_gcsfuse, to bypass the change in go get behaviour introduced in 1.17 and enforced in go 1.22. 2. Fix some paths and commands etc. accordingly in the dockerfile. * Fix package_gcsfuse/dockerfile for go 1.22 Does the following 1. Create a go module (go.mod) in a directory package_gcsfuse, to bypass the change in go get behaviour introduced in 1.17 and enforced in go 1.22. 2. Fix some paths and commands etc. accordingly in the dockerfile. * Switch containerize*/Dockerfile to use git clone * Switch package*/Dockerfile to use git clone * Replace /go with ${GOPATH} * Minimize run of git clone Fetch only the last commit state in docker files during git clone to reduce its runtime. This reduces the runtime of git clone dramatically. * Upgrade from go 1.22.0 to 1.22.1

gargnitingoogle force-pushed the gargnitin/fix-dockerfile-go-get branch 3 times, most recently from eb68b71 to 8685637 Compare March 5, 2024 10:49

gargnitingoogle changed the title ~~Replace go get with go install in Dockerfiles~~ Fix dockerfile for go 1.22 Mar 5, 2024

gargnitingoogle changed the title ~~Fix dockerfile for go 1.22~~ Upgrade to go 1.22 Mar 5, 2024

gargnitingoogle force-pushed the gargnitin/fix-dockerfile-go-get branch from 8685637 to e2d814e Compare March 5, 2024 11:05

gargnitingoogle changed the title ~~Upgrade to go 1.22~~ Upgrade to go 1.22 (with fix for dockerfiles) Mar 5, 2024

gargnitingoogle added execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests labels Mar 5, 2024

gargnitingoogle marked this pull request as ready for review March 5, 2024 11:20

gargnitingoogle requested review from sethiay, vadlakondaswetha and raj-prince as code owners March 5, 2024 11:20

gargnitingoogle force-pushed the gargnitin/fix-dockerfile-go-get branch from e2d814e to 6952e54 Compare March 6, 2024 04:37

gargnitingoogle assigned sethiay Mar 6, 2024

gargnitingoogle removed execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests labels Mar 6, 2024

gargnitingoogle force-pushed the gargnitin/fix-dockerfile-go-get branch from 6952e54 to 1c51816 Compare March 7, 2024 04:19

gargnitingoogle marked this pull request as draft March 7, 2024 04:20

gargnitingoogle marked this pull request as ready for review March 7, 2024 14:37

gargnitingoogle added execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests labels Mar 7, 2024

gargnitingoogle force-pushed the gargnitin/fix-dockerfile-go-get branch from f3af723 to d45d298 Compare March 8, 2024 10:12

gargnitingoogle assigned raj-prince and unassigned sethiay Mar 8, 2024

gargnitingoogle force-pushed the gargnitin/fix-dockerfile-go-get branch from 36971eb to 50d2f6f Compare March 11, 2024 04:41

raj-prince reviewed Mar 11, 2024

View reviewed changes

tools/containerize_gcsfuse_docker/Dockerfile Outdated Show resolved Hide resolved

raj-prince reviewed Mar 11, 2024

View reviewed changes

gargnitingoogle force-pushed the gargnitin/fix-dockerfile-go-get branch from 2106bc6 to 3e2ecde Compare March 11, 2024 11:05

gargnitingoogle added 8 commits March 12, 2024 02:12

Upgrade to golang 1.22 (without dockerfile fix)

9ec66d1

Reapply "Upgrade to golang 1.22 (#1753)" (#1766) This reverts commit a63a46f and fixes merge conflicts with golang 1.21.7 upgrade which went in earlier.

Fix containerize_gcsfuse/dockerfile for go 1.22

d6959a6

Does the following 1. Create a go module (go.mod) in a directory package_gcsfuse, to bypass the change in go get behaviour introduced in 1.17 and enforced in go 1.22. 2. Fix some paths and commands etc. accordingly in the dockerfile.

Fix package_gcsfuse/dockerfile for go 1.22

0c3c9b3

Does the following 1. Create a go module (go.mod) in a directory package_gcsfuse, to bypass the change in go get behaviour introduced in 1.17 and enforced in go 1.22. 2. Fix some paths and commands etc. accordingly in the dockerfile.

Switch containerize*/Dockerfile to use git clone

ce54c36

Switch package*/Dockerfile to use git clone

bb56f3c

Replace /go with ${GOPATH}

a812499

Minimize run of git clone

18e7b7b

Fetch only the last commit state in docker files during git clone to reduce its runtime. This reduces the runtime of git clone dramatically.

Upgrade from go 1.22.0 to 1.22.1

1144c0a

gargnitingoogle force-pushed the gargnitin/fix-dockerfile-go-get branch from 3e2ecde to 1144c0a Compare March 12, 2024 02:14

gargnitingoogle changed the title ~~Upgrade to go 1.22 (with fix for dockerfiles)~~ Upgrade to go 1.22.1 (with fix for dockerfiles) Mar 12, 2024

gargnitingoogle requested a review from raj-prince March 12, 2024 03:54

raj-prince approved these changes Mar 12, 2024

View reviewed changes

gargnitingoogle merged commit ef48953 into master Mar 12, 2024
8 checks passed

gargnitingoogle deleted the gargnitin/fix-dockerfile-go-get branch March 12, 2024 10:51

BrewTestBot mentioned this pull request Apr 23, 2024

gcsfuse 2.0.1 Homebrew/homebrew-core#169823

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to go 1.22.1 (with fix for dockerfiles) #1764

Upgrade to go 1.22.1 (with fix for dockerfiles) #1764

gargnitingoogle commented Mar 4, 2024 •

edited

gargnitingoogle commented Mar 6, 2024

gargnitingoogle commented Mar 7, 2024

raj-prince left a comment

gargnitingoogle commented Mar 11, 2024

gargnitingoogle commented Mar 12, 2024 •

edited

gargnitingoogle commented Mar 12, 2024

Upgrade to go 1.22.1 (with fix for dockerfiles) #1764

Upgrade to go 1.22.1 (with fix for dockerfiles) #1764

Conversation

gargnitingoogle commented Mar 4, 2024 • edited

Description

Link to the issue in case of a bug fix.

Testing details

gargnitingoogle commented Mar 6, 2024

gargnitingoogle commented Mar 7, 2024

raj-prince left a comment

Choose a reason for hiding this comment

gargnitingoogle commented Mar 11, 2024

gargnitingoogle commented Mar 12, 2024 • edited

gargnitingoogle commented Mar 12, 2024

gargnitingoogle commented Mar 4, 2024 •

edited

gargnitingoogle commented Mar 12, 2024 •

edited