Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling gRPC test temporarily #1929

Merged
merged 4 commits into from
May 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
set -e

readonly RUN_E2E_TESTS_ON_INSTALLED_PACKAGE=true
readonly SKIP_NON_ESSENTIAL_TESTS_ON_PACKAGE=true

cd "${KOKORO_ARTIFACTS_DIR}/github/gcsfuse"
echo "Building and installing gcsfuse..."
Expand All @@ -30,4 +31,4 @@ git checkout $commitId

echo "Running e2e tests on installed package...."
# $1 argument is refering to value of testInstalledPackage
./tools/integration_tests/run_e2e_tests.sh $RUN_E2E_TESTS_ON_INSTALLED_PACKAGE
./tools/integration_tests/run_e2e_tests.sh $RUN_E2E_TESTS_ON_INSTALLED_PACKAGE $SKIP_NON_ESSENTIAL_TESTS_ON_PACKAGE
2 changes: 1 addition & 1 deletion tools/cd_scripts/e2e_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ git checkout $(sed -n 2p ~/details.txt) |& tee -a ~/logs.txt

#run tests with testbucket flag
set +e
GODEBUG=asyncpreemptoff=1 CGO_ENABLED=0 go test ./tools/integration_tests/... -p 1 --integrationTest -v --testbucket=$(sed -n 3p ~/details.txt) --testInstalledPackage --timeout=60m &>> ~/logs.txt
GODEBUG=asyncpreemptoff=1 CGO_ENABLED=0 go test ./tools/integration_tests/... -p 1 -short --integrationTest -v --testbucket=$(sed -n 3p ~/details.txt) --testInstalledPackage --timeout=60m &>> ~/logs.txt

if [ $? -ne 0 ];
then
Expand Down
10 changes: 6 additions & 4 deletions tools/integration_tests/implicit_dir/implicit_dir_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,13 @@ func TestMain(m *testing.M) {
log.Fatalf("client.CreateStorageClient: %v", err)
}

flags := [][]string{
{"--implicit-dirs"},
{"--client-protocol=grpc", "--implicit-dirs=true"}}
flagsSet := [][]string{{"--implicit-dirs"}}

successCode := implicit_and_explicit_dir_setup.RunTestsForImplicitDirAndExplicitDir(flags, m)
if !testing.Short() {
flagsSet = append(flagsSet, []string{"--client-protocol=grpc", "--implicit-dirs=true"})
}

successCode := implicit_and_explicit_dir_setup.RunTestsForImplicitDirAndExplicitDir(flagsSet, m)

// Close storage client and release resources.
storageClient.Close()
Expand Down
5 changes: 2 additions & 3 deletions tools/integration_tests/operations/operations_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,10 @@ func TestMain(m *testing.M) {
// By default, creating emptyFile is disabled.
{"--implicit-dirs=true"},
{"--implicit-dirs=false"},
{"--experimental-enable-json-read=true", "--implicit-dirs=true"},
{"--client-protocol=grpc", "--implicit-dirs=true"}}
{"--experimental-enable-json-read=true", "--implicit-dirs=true"}}

if !testing.Short() {
flagsSet = append(flagsSet, []string{"--client-protocol=grpc", "--implicit-dirs=false"})
flagsSet = append(flagsSet, []string{"--client-protocol=grpc", "--implicit-dirs=true"})
raj-prince marked this conversation as resolved.
Show resolved Hide resolved
}

mountConfigFlags := createMountConfigsAndEquivalentFlags()
Expand Down
Loading