Warn on md-prefetch enabled w/o md-cache #1944
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1944 +/- ##
==========================================
+ Coverage 60.76% 60.78% +0.01%
==========================================
Files 130 130
Lines 12397 12415 +18
==========================================
+ Hits 7533 7546 +13
- Misses 4526 4531 +5
Partials 338 338
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Base automatically changed from
gargnitin/listing-during-mount/production/v1
to
master
May 24, 2024 10:21
gargnitingoogle
force-pushed
the
gargnitin/listing-during-mount/production/v2
branch
from
1b785ca
to
e7bbd0a
Compare
sethiay
reviewed
May 27, 2024
| } | ||
|
|
||
| func isTypeCacheEnabled(metadataCacheTTL time.Duration, typeCacheMaxSizeMB int) bool { | ||
| if metadataCacheTTL <= 0 || typeCacheMaxSizeMB == 0 || typeCacheMaxSizeMB < -1 { |
There was a problem hiding this comment.
check if typeCacheMaxSizeMB < -1 is required or not. if not why and if yes why.
| return true | ||
| } | ||
|
|
||
| func isStatCacheEnabled(metadataCacheTTL time.Duration, statCacheMaxSizeMB uint64) bool { |
There was a problem hiding this comment.
should we add these helper methods and their test cases somewhere apt inside internal directory ? trying to keep main.go clean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Warn on md-prefetch enabled w/o md-cache
In other words, log warnings if user has enabled metadata-prefetch through
metadata-prefetch-on-mountflag but has either the type-cache or the stat-cache disabled through their ttl or size.This is on top of #1930
Link to the issue in case of a bug fix.
NA
Testing details