Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config CLI Parity] temp-dir should be of type resolved path #2059

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

ashmeenkaur
Copy link
Collaborator

Description

temp-dir should be of type resolved path.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@ashmeenkaur ashmeenkaur changed the title temp-dir should be resolved path temp-dir should be of type resolved path Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.97%. Comparing base (a1d8786) to head (00483c1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2059      +/-   ##
==========================================
- Coverage   72.00%   71.97%   -0.03%     
==========================================
  Files          99       99              
  Lines       10869    10869              
==========================================
- Hits         7826     7823       -3     
- Misses       2711     2713       +2     
- Partials      332      333       +1     
Flag Coverage Δ
unittests 71.97% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashmeenkaur ashmeenkaur marked this pull request as ready for review June 24, 2024 14:24
@ashmeenkaur ashmeenkaur requested review from kislaykishore and a team as code owners June 24, 2024 14:24
@ashmeenkaur ashmeenkaur requested a review from sethiay June 24, 2024 14:24
@ashmeenkaur ashmeenkaur merged commit e247b84 into master Jun 24, 2024
13 checks passed
@ashmeenkaur ashmeenkaur deleted the temp-dir_should_be_resolved_path branch June 24, 2024 18:09
@ashmeenkaur ashmeenkaur changed the title temp-dir should be of type resolved path [Config CLI Parity] temp-dir should be of type resolved path Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants