Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test in GKE environment #2076

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Fix test in GKE environment #2076

merged 1 commit into from
Jun 28, 2024

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Jun 28, 2024

Description

I've implemented a check for HierarchicalNamespace.Enabled to incorporate the HNS flag in end-to-end tests. Older buckets lack this attribute, potentially leading to nil pointer exceptions. To mitigate this, I've added a fix to verify the presence of HierarchicalNamespace.

Alternatively, the GKE team could create a new bucket where the HierarchicalNamespace attribute already defined.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - Automated and Ran mounted directory script

@Tulsishah Tulsishah added the execute-integration-tests Run only integration tests label Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.06%. Comparing base (3995bfb) to head (5221a8b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2076      +/-   ##
==========================================
+ Coverage   71.98%   72.06%   +0.07%     
==========================================
  Files         100       99       -1     
  Lines       11207    10863     -344     
==========================================
- Hits         8067     7828     -239     
+ Misses       2806     2706     -100     
+ Partials      334      329       -5     
Flag Coverage Δ
unittests 72.06% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tulsishah Tulsishah marked this pull request as ready for review June 28, 2024 07:35
@Tulsishah Tulsishah requested a review from a team as a code owner June 28, 2024 07:35
@Tulsishah Tulsishah requested a review from sethiay June 28, 2024 07:35
@Tulsishah Tulsishah merged commit c86aa80 into master Jun 28, 2024
15 checks passed
@Tulsishah Tulsishah deleted the fix_gke_e2e_test2 branch July 19, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants