Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCSFuse code change to write the logs to syslog files #984

Merged
merged 5 commits into from
Mar 6, 2023

Conversation

raj-prince
Copy link
Collaborator

@raj-prince raj-prince commented Mar 2, 2023

Description

  1. Reverts Revert "GCSFuse code change to write the logs to syslog files" #977
  2. Modified log behavior - If user passes --log-file in case all the logs will be written to given log file. Otherwise in background mode gcsfuse will write the log to syslog and in foreground mode logs will be printed to console as stdout/err.

Testing

  1. Manual - Checked all the four behaviors manually.
  2. Integration Test - NA
  3. Unit Test - NA

@raj-prince raj-prince changed the title Revert "Revert "GCSFuse code change to write the logs to syslog files"" [Don't review] GCSFuse code change to write the logs to syslog files Mar 2, 2023
@raj-prince raj-prince changed the title [Don't review] GCSFuse code change to write the logs to syslog files GCSFuse code change to write the logs to syslog files Mar 3, 2023
@raj-prince raj-prince self-assigned this Mar 3, 2023
internal/logger/logger.go Outdated Show resolved Hide resolved
internal/logger/logger.go Outdated Show resolved Hide resolved
internal/logger/logger.go Outdated Show resolved Hide resolved
internal/logger/logger.go Outdated Show resolved Hide resolved
@raj-prince raj-prince merged commit b012d8f into master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants