speech: add livecaption #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broady
reviewed
Nov 17, 2016
| defer conn.Close() | ||
|
|
||
| // [START speech_streaming_mic_recognize] | ||
| stream, err := speech.NewSpeechClient(conn).StreamingRecognize(ctx) |
There was a problem hiding this comment.
| if err != nil { | ||
| log.Fatal(err) | ||
| } | ||
| // send the initial configuration message. |
There was a problem hiding this comment.
sentence casing, please (and in the two comments below)
// Send the initial configuration message.
| return // nothing else to pipe, kill this goroutine | ||
| } | ||
| if err != nil { | ||
| log.Printf("Reading stdin error: %v", err) |
There was a problem hiding this comment.
"Could not read from stdin"
| AudioContent: buf[:n], | ||
| }, | ||
| }); err != nil { | ||
| log.Printf("Sending audio error: %v", err) |
| break | ||
| } | ||
| if err != nil { | ||
| log.Fatalf("stream.Recv error: %v", err) |
There was a problem hiding this comment.
"stream.Recv: %v"
unless there's a better way to describe what might have happened
| log.Fatalf("stream.Recv error: %v", err) | ||
| } | ||
| if err := resp.Error; err != nil { | ||
| log.Fatalf("Recieved error resp: %v", err) |
…amples into livecaption
broady
reviewed
Nov 17, 2016
| buf := make([]byte, 1024) | ||
| for { | ||
| n, err := os.Stdin.Read(buf) | ||
| if err == io.EOF { | ||
| return // nothing else to pipe, kill this goroutine | ||
| return // Nothing else to pipe, returns from this goroutine. |
|
LGTM, one nit |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.