Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(run): Add sigterm handler sample #1902
feat(run): Add sigterm handler sample #1902
Changes from 18 commits
d2e8170
f4f0b61
4b38f58
746edb8
46a001d
affc024
78665ee
a0688fb
bbbaedd
c48ec7a
108e840
5d131ca
f867aee
d609a0c
368b8fa
0953170
9043cca
d301f72
e86c015
b4a535d
dae3a0f
79c29ee
4d11b54
52db080
f1c6a3d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure where the comment went. But, I'd expect any DB connections, etc. to handled outside this
defer
call. I might be missing something.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grayside please advise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the idiomatic approach here, did a little searching to see how folks talk about this, and in the first 5 results, 2 of them do cleanup inside the defer and three just do them after the shutdown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Future: Nice function! Seems like a good candidate to move into cloudrunci.