pubsub: deflake tests #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the Project ID as a prefix to ensure tests can run in parallel. Fixes #219.
|
Also seeing this, which seems to be correlated to pub/sub IAM tests: and... |
|
/cc @rakyll |
rakyll
reviewed
Apr 4, 2017
pubsub/topics/main_test.go
Outdated
| r.Errorf("getPolicy: %v", err) | ||
| } | ||
| if role, member := iam.Editor, "group:cloud-logs@google.com"; !policy.HasRole(member, role) { | ||
| r.Errorf("want %q as viewer, got %v", member, policy) |
There was a problem hiding this comment.
got first, want second: https://github.com/golang/go/wiki/CodeReviewComments#useful-test-failures
There was a problem hiding this comment.
The values aren't being checked for equality.
It's more like got HasRole(role, member)=false; want true; policy = %v
pubsub/topics/main_test.go
Outdated
| r.Errorf("want %q as viewer, got %v", member, policy) | ||
| } | ||
| if role, member := iam.Viewer, iam.AllUsers; !policy.HasRole(member, role) { | ||
| r.Errorf("want %q as viewer, got %v", member, policy) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Project ID as a prefix to ensure tests can run in parallel.
Fixes #219.