feat(pubsub): add clear export subscription samples #3159
Conversation
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
product-auto-label
bot
added
api: pubsub
hongalex
changed the title
|
|
||
| pushSubID := subID + "-push" | ||
| testutil.Retry(t, 10, time.Second, func(r *testutil.R) { | ||
| buf := new(bytes.Buffer) |
There was a problem hiding this comment.
nit: I prefer to declare & initialize a buffer like so:
var buf bytes.Buffer
| if err != nil { | ||
| r.Errorf("CreateTopic: %v", err) | ||
| } | ||
| buf := new(bytes.Buffer) |
There was a problem hiding this comment.
See previous about declaring & initializing a buffer.
| }) | ||
|
|
||
| testutil.Retry(t, 10, time.Second, func(r *testutil.R) { | ||
| buf := new(bytes.Buffer) |
There was a problem hiding this comment.
See previous about declaring & initializing a buffer.
…-samples into feat-pubsub-clear-bq-sub
|
Hi @hongalex, This PR looks to be pretty stale, and need some attention to get the tests passing. I'll move it to Draft for now, but please reach out if you need any help getting this PR merged. |
This PR corresponds to the changes in googleapis/google-cloud-go#8040. We currently were not catching an issue where clearing bigquery subscription fails. This adds the appropriate sample + test to catch this. A similar sample and test is added for Push (to endpoint) subscriptions.
This PR also switches the BQ dataset/table used from dynamically created to a reused one. Since we aren't actually writing to these tables, there's no harm in reusing a predefined table. This prevents a slow leakage of tables/datasets over time when tests invocations inevitably fail.