Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner): modifying readBatchData sample to add snippet with databoost #3177

Merged
merged 13 commits into from Aug 7, 2023
Merged

feat(spanner): modifying readBatchData sample to add snippet with databoost #3177

merged 13 commits into from Aug 7, 2023

Conversation

harshachinta
Copy link
Contributor

Updating Batch Sample to add databoost

References
googleapis/google-cloud-go#8152

@harshachinta harshachinta requested review from a team as code owners June 20, 2023 14:27
@product-auto-label product-auto-label bot added api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples. labels Jun 20, 2023
@harshachinta
Copy link
Contributor Author

@telpirion
This is a modification to the PR #3161 that has been approved. There have been changes to the way we are exposing the feature. Can you please review this PR on priority?

@harshachinta harshachinta mentioned this pull request Jun 20, 2023
Closed
@telpirion telpirion self-assigned this Jun 21, 2023
telpirion
telpirion previously requested changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@telpirion telpirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing. Please fix.

@telpirion telpirion added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 22, 2023
@telpirion telpirion added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Aug 3, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2023
@harshachinta
Copy link
Contributor Author

We will be merging the samples in few weeks. Thanks @telpirion for keeping an eye on this PR.

@harshachinta
Copy link
Contributor Author

The tests are passing now.

@rahul2393 rahul2393 enabled auto-merge (squash) August 7, 2023 09:14
@muncus muncus self-assigned this Aug 7, 2023
@muncus muncus removed the request for review from telpirion August 7, 2023 20:41
@muncus muncus dismissed telpirion’s stale review August 7, 2023 20:42

tests are passing, but @telpirion is OOO this week and won't be able to re-review.

@rahul2393 rahul2393 merged commit 6e28f02 into GoogleCloudPlatform:main Aug 7, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muncus muncus muncus approved these changes

@rahul2393 rahul2393 rahul2393 approved these changes

@telpirion telpirion telpirion left review comments

Assignees

@muncus muncus

@telpirion telpirion

Labels
api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@harshachinta @muncus @telpirion @rahul2393 @kokoro-team