-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vertextai): video with audio #4113
feat(vertextai): video with audio #4113
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see this sample, it might directly help some of my own learning in this space!
// generateMultimodalContent generates a response into w, based upon the prompt | ||
// and video provided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: This sentence describes what the code does, but I think it could provide a bit more insight into the goal and what is meant by "w".
Consider addressing why the sample is interesting:
// generateMultimodalContent generates a response into w, based upon the prompt | |
// and video provided. | |
// generateMultimodalContent shows how to send video and text prompts to a model, writing the response to the provided io.Writer. |
|
||
client, err := genai.NewClient(ctx, projectID, location) | ||
if err != nil { | ||
return fmt.Errorf("unable to create client: %v", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking: Prefer error wrapping with %w in this and other locations.
kokoro failing with |
Go version of the Python sample at https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/generative_ai/gemini_video_audio.py
Region tag
generativeaionvertexai_gemini_video_with_audio
.