Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vertextai): video with audio #4113

Merged

Conversation

Deleplace
Copy link
Contributor

Go version of the Python sample at https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/generative_ai/gemini_video_audio.py

Region tag generativeaionvertexai_gemini_video_with_audio.

@Deleplace Deleplace requested a review from a team as a code owner April 25, 2024 13:12
Copy link

snippet-bot bot commented Apr 25, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 25, 2024
@Deleplace Deleplace enabled auto-merge (squash) April 25, 2024 13:22
Copy link
Contributor

@grayside grayside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this sample, it might directly help some of my own learning in this space!

Comment on lines 30 to 31
// generateMultimodalContent generates a response into w, based upon the prompt
// and video provided.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: This sentence describes what the code does, but I think it could provide a bit more insight into the goal and what is meant by "w".

Consider addressing why the sample is interesting:

Suggested change
// generateMultimodalContent generates a response into w, based upon the prompt
// and video provided.
// generateMultimodalContent shows how to send video and text prompts to a model, writing the response to the provided io.Writer.


client, err := genai.NewClient(ctx, projectID, location)
if err != nil {
return fmt.Errorf("unable to create client: %v", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking: Prefer error wrapping with %w in this and other locations.

@Deleplace
Copy link
Contributor Author

kokoro failing with Test_functionCallsChat: rpc error: .... but unrelated to the current code change

@Deleplace Deleplace requested a review from grayside April 29, 2024 08:12
@Deleplace Deleplace added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2024
@Deleplace Deleplace merged commit 659f01f into GoogleCloudPlatform:main May 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants