Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vertexai): Add stream text sample #4147

Merged
merged 5 commits into from
May 29, 2024

Conversation

ymotongpoo
Copy link
Member

Description

Go porting of the following Python sample:
https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/generative_ai/inference/stream_text_basic.py

Region tag is generativeaionvertexai_stream_text_basic

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@ymotongpoo ymotongpoo requested a review from a team as a code owner May 23, 2024 03:47
Copy link

snippet-bot bot commented May 23, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link

conventional-commit-lint-gcf bot commented May 23, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 23, 2024
Go porting of the following Python sample:
https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/generative_ai/inference/stream_text_basic.py

Region tag is `generativeaionvertexai_stream_text_basic`
Copy link
Contributor

@grayside grayside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the sample, I've asked for a small change to unblock approval. The feedback is identical to what I left on #4148

vertexai/stream-text-basic/streamtextbasic.go Outdated Show resolved Hide resolved
vertexai/stream-text-basic/streamtextbasic.go Outdated Show resolved Hide resolved
Copy link
Contributor

@grayside grayside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ymotongpoo ymotongpoo merged commit db4a703 into GoogleCloudPlatform:main May 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants