-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vertexai): Add stream text sample #4147
feat(vertexai): Add stream text sample #4147
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Go porting of the following Python sample: https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/generative_ai/inference/stream_text_basic.py Region tag is `generativeaionvertexai_stream_text_basic`
471fee2
to
fa65363
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the sample, I've asked for a small change to unblock approval. The feedback is identical to what I left on #4148
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Description
Go porting of the following Python sample:
https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/generative_ai/inference/stream_text_basic.py
Region tag is
generativeaionvertexai_stream_text_basic
Checklist
go test -v ./..
(see Testing)gofmt
(see Formatting)go vet
(see Formatting)