Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compute): compute_ip_address_assign_static_existing_vm sample #4166

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

irudykss
Copy link
Collaborator

@irudykss irudykss commented Jun 4, 2024

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 4, 2024
@irudykss irudykss force-pushed the samples/compute_ip_address_assign_static_existing_vm branch from 0fbf981 to 7d580af Compare June 10, 2024 07:31
@irudykss irudykss marked this pull request as ready for review June 10, 2024 07:40
@irudykss irudykss requested review from a team as code owners June 10, 2024 07:40
Copy link

snippet-bot bot commented Jun 10, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@irudykss irudykss changed the title Samples/compute ip address assign static existing vm feat(compute): compute_ip_address_assign_static_existing_vm sample Jun 10, 2024
@irudykss irudykss added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 10, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 10, 2024
@irudykss irudykss added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 10, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 10, 2024
@product-auto-label product-auto-label bot added the api: compute Issues related to the Compute Engine API. label Jun 10, 2024
@irudykss irudykss enabled auto-merge (squash) June 10, 2024 14:19
@irudykss irudykss force-pushed the samples/compute_ip_address_assign_static_existing_vm branch from 7d580af to 2a99285 Compare June 13, 2024 07:45
@irudykss irudykss added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 13, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 13, 2024
@irudykss irudykss requested a review from muncus June 13, 2024 08:08
@irudykss irudykss added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 13, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 13, 2024
compute/address/address_test.go Outdated Show resolved Hide resolved
compute/address/address_test.go Outdated Show resolved Hide resolved
@muncus muncus self-assigned this Jun 13, 2024
@irudykss irudykss force-pushed the samples/compute_ip_address_assign_static_existing_vm branch 2 times, most recently from 343b232 to 83d9998 Compare June 14, 2024 08:19
@irudykss irudykss force-pushed the samples/compute_ip_address_assign_static_existing_vm branch from 83d9998 to a91d612 Compare June 14, 2024 08:21
@irudykss irudykss added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 14, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 14, 2024
@irudykss irudykss added kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 17, 2024
@irudykss irudykss added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2024
@irudykss irudykss requested a review from muncus June 17, 2024 08:44
@irudykss irudykss added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 17, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2024
@muncus muncus added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2024
@irudykss irudykss merged commit f80fd3c into main Jun 17, 2024
11 checks passed
@irudykss irudykss deleted the samples/compute_ip_address_assign_static_existing_vm branch June 17, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants