-
Notifications
You must be signed in to change notification settings - Fork 49
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
While deploy job is running, certain things in Eclipse go into a weird state #1603
Comments
It's actually easy to reproduce. All you have to do is to make private IStatus deployProject(Path credentialFile, IPath stagingDirectory, IProgressMonitor monitor) {
while (!monitor.isCanceled()) try {
Thread.sleep(1000);
} catch (Exception e) {}
RecordProcessError deployExitListener = new RecordProcessError();
...
return deployExitListener.getExitStatus();
} |
My suspicion is that the deploy job holds a lock or something, and it interferes with something workspace-wide. |
That NPE looks like a bug:
Here's for (ILaunch launch : getLaunchManager().getLaunches()) {
if (launch.isTerminated()
|| launch.getLaunchConfiguration().getType() != configuration.getType()) { // line 124
continue;
} |
What if you don't use JSPs? Is it possible Jasper is sharing space somehow? |
In fact, I can reproduce these using only the non-Maven helloworld projects, which don't have any JSP (although of course it may not guarantee Jasper is not kicked in.) |
I wonder if you could use |
It's surprising that this happens whenever any public class StandardDeployCommandHandler extends AbstractHandler {
@Override
public Object execute(ExecutionEvent event) throws ExecutionException {
new WorkspaceJob("My Awesome Workspace Job") {
@Override
public IStatus runInWorkspace(IProgressMonitor monitor) throws CoreException {
while (!monitor.isCanceled()) try {
Thread.sleep(1000);
} catch (Exception e) {}
return Status.OK_STATUS;
}
}.schedule();
return null;
} Not sure if it's the deploy job, the project creation, or both that need to be fixed. |
This is a very weird bug.
It is a bit tricky to reproduce. You need to somehow make a deploy take a long time. (I have a GCP project where it takes several minutes to deploy any app.)
Now, while the job from 1 is running, if you run the project from 2 locally, the server will come up, but it's not functional. Some error messages from the dev_appserver:
Also, while the job from 1 is running, if you deploy the project from 2, it will fail at the staging step:
If the job from 1 is finally complete, the project 2 will eventually show a warning marker:
I can always reproduce this up to this point.
At this point, I also observed other weird things. For example, I tried to stop the dev_appserver I ran before, but the server was stuck at the "Stopping, Synchronized" state for several minutes. It eventually went down, but when I try to re-launch the dev_appserver, it immediately fails with a NullPointerException:
Also, deploying the project from 2 again still fails for some time, but somewhat differently: it passed the staging, but pre-compiling fails on the server side:
The text was updated successfully, but these errors were encountered: