Use project SDK when staging App Engine apps for deploy #2195

NicolaSpreafico · 2017-07-25T08:06:48Z

Eclipse version: Oxygen Release (4.7.0)
Cloud Tools for Eclipse version: 1.2.0.201706082053
Google Cloud SDK version: 163.0.0
OS: Windows 10 v1703
Java version: jdk1.8.0_111

I have a Maven App Engine standard project which contains jsp files (and this is the reason I think that the project is looking for JDK)

If I deploy the project with appengine:deploy works fine
If I deploy with the plugin I get

Unable to stage:
java.lang.RuntimeException: Cannot get the System Java Compiler. Please use a JDK, not a JRE.
	at com.google.appengine.tools.admin.Application.compileJspJavaFiles(Application.java:1201)
	at com.google.appengine.tools.admin.Application.compileJsps(Application.java:1178)
	at com.google.appengine.tools.admin.Application.populateStagingDirectory(Application.java:901)
	at com.google.appengine.tools.admin.Application.createStagingDirectory(Application.java:809)
	at com.google.appengine.tools.admin.AppAdminImpl.stageApplication(AppAdminImpl.java:539)
	at com.google.appengine.tools.admin.AppAdminImpl.stageApplicationWithDefaultResourceLimits(AppAdminImpl.java:492)
	at com.google.appengine.tools.admin.AppCfg$StagingAction.execute(AppCfg.java:2510)
	at com.google.appengine.tools.admin.AppCfg.executeAction(AppCfg.java:393)
	at com.google.appengine.tools.admin.AppCfg.<init>(AppCfg.java:216)
	at com.google.appengine.tools.admin.AppCfg.<init>(AppCfg.java:116)
	at com.google.appengine.tools.admin.AppCfg.main(AppCfg.java:112)
com.google.appengine.tools.admin.AdminException: Unable to stage app: Cannot get the System Java Compiler. Please use a JDK, not a JRE.
	at com.google.appengine.tools.admin.AppAdminImpl.stageApplication(AppAdminImpl.java:543)
	at com.google.appengine.tools.admin.AppAdminImpl.stageApplicationWithDefaultResourceLimits(AppAdminImpl.java:492)
	at com.google.appengine.tools.admin.AppCfg$StagingAction.execute(AppCfg.java:2510)
	at com.google.appengine.tools.admin.AppCfg.executeAction(AppCfg.java:393)
	at com.google.appengine.tools.admin.AppCfg.<init>(AppCfg.java:216)
	at com.google.appengine.tools.admin.AppCfg.<init>(AppCfg.java:116)
	at com.google.appengine.tools.admin.AppCfg.main(AppCfg.java:112)
Caused by: java.lang.RuntimeException: Cannot get the System Java Compiler. Please use a JDK, not a JRE.
	at com.google.appengine.tools.admin.Application.compileJspJavaFiles(Application.java:1201)
	at com.google.appengine.tools.admin.Application.compileJsps(Application.java:1178)
	at com.google.appengine.tools.admin.Application.populateStagingDirectory(Application.java:901)
	at com.google.appengine.tools.admin.Application.createStagingDirectory(Application.java:809)
	at com.google.appengine.tools.admin.AppAdminImpl.stageApplication(AppAdminImpl.java:539)
	... 6 more

I don't think it is a project or OS error because using directly Maven the deploy works fine

Here is my Java installation

Eclipse configuration

Project configuration

The text was updated successfully, but these errors were encountered:

chanseokoh · 2017-07-25T12:48:13Z

I suspect that JRE was used to start your Eclipse. Can you try changining it to JDK to see if that works? I believe you can configure it through eclipse.ini.

NicolaSpreafico · 2017-07-25T14:35:25Z

I found the JRE indeed

And I changed it to JDK

And the deploy worked.
Thanks for the tip

patflynn · 2017-07-25T14:53:38Z

The bug really needs to be that the staging jsp compiler needs to use the project configured jdk. We've seen this problem in other plugins as well.

patflynn · 2017-07-25T14:53:54Z

@loosebazooka Does this bug get filed against App Engine SDK?

chanseokoh · 2017-07-25T14:55:33Z

Maybe it's the fault of CT4E that does not use the project JDK. I'll take a look first.

loosebazooka · 2017-07-25T15:06:27Z

It probably isn't the App Engine SDK's fault. I think we need to trigger "staging" or whatever using the project sdk, since it's just using the configuration that launched staging in the first place.

briandealwis · 2017-07-25T15:55:08Z

I think @chanseokoh's right: CT4E isn't configuring javaHome() on the CloudSdk instance.

chanseokoh · 2017-07-25T17:19:09Z

@NicolaSpreafico I think it's possible that your JSPs will be complied with Java 8 (although it will be compiled with the '--source 1.7' option) and this might cause a problem if deploying to App Engine standard Java 7. If so, please double-check you don't have any problem.

NicolaSpreafico · 2017-07-26T09:03:07Z

After updating Eclipse configuration from JRE to SDK the deploy problem is solved and I can confirm that the JSP are working fine

briandealwis · 2017-07-27T17:07:19Z

It's odd that AppCfg is wanting to use the JDK compiler where as Jasper at runtime uses an embedded ECJ (#590).

chanseokoh · 2017-07-27T17:59:44Z

Had an offline discussion with @briandealwis. We believe as long as it's not a JRE, using higher versions of Java compilers won't be a problem for compiling JSPs during staging (which is done through -source 1.7, although it shows a warning warning: [options] bootstrap class path not set in conjunction with -source 1.7).

So, the strategy to find any usable JDK will be like this:

get the project's JRE and check if it is a JDK (resolve the compiler class)
if not, cycle through the other installed JREs of that type and see if any of them are JDKs
if none, raise an error

patflynn · 2017-07-27T23:16:29Z

Why not just raise an error immediately after step 1?

…

On Thu, Jul 27, 2017 at 10:59 AM, Chanseok Oh ***@***.***> wrote: Had an offline discussion with @briandealwis <https://github.com/briandealwis>. We believe as long as it's not a JRE, using higher versions of Java compilers won't be a problem for compiling JSPs during staging (which is done through -source 1.7, although it shows a warning warning: [options] bootstrap class path not set in conjunction with -source 1.7). So, the strategy is find a JDK will be like this: 1. get the project's JRE and check if it is a JDK (resolve the compiler class) 2. if not, cycle through the other installed JREs of that type and see if any of them are JDKs 3. if none, raise an error — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2195 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHf5HY4siYwWHy7T-jlRfHJCyN71HfRPks5sSNAQgaJpZM4OiM-D> .

chanseokoh · 2017-07-28T15:38:12Z

Why not just raise an error immediately after step 1?

I think that's a simple and good idea. Users should have a JDK, and making them to set it to their project sounds right.

chanseokoh · 2017-07-31T18:23:36Z

Didn't expect this to be closed. (Striking words doesn't seem to work.)

chanseokoh · 2017-08-10T19:19:11Z

On second thought, I think we can close this now. If a project's JRE is not a JDK (which will be very unlikely anyway) or if it can't find a JDK anywhere, it will fail with the message that it's not a JDK. Users will then naturally configure the project's JRE to be a JDK.

NicolaSpreafico closed this as completed Jul 25, 2017

briandealwis reopened this Jul 25, 2017

chanseokoh self-assigned this Jul 25, 2017

chanseokoh changed the title ~~Cannot get the System Java Compiler while deploying with plugin~~ Use project SDK when deploying App Engine apps Jul 25, 2017

chanseokoh mentioned this issue Jul 25, 2017

Set project JDK for deploy staging #2198

Merged

chanseokoh changed the title ~~Use project SDK when deploying App Engine apps~~ Use project SDK when staging App Engine apps for deploy Jul 26, 2017

chanseokoh closed this as completed in #2198 Jul 31, 2017

chanseokoh reopened this Jul 31, 2017

chanseokoh closed this as completed Aug 10, 2017

chanseokoh mentioned this issue Nov 1, 2017

JDK Staging error: unable to stage app #2548

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use project SDK when staging App Engine apps for deploy #2195

Use project SDK when staging App Engine apps for deploy #2195

NicolaSpreafico commented Jul 25, 2017

chanseokoh commented Jul 25, 2017

NicolaSpreafico commented Jul 25, 2017

patflynn commented Jul 25, 2017

patflynn commented Jul 25, 2017

chanseokoh commented Jul 25, 2017

loosebazooka commented Jul 25, 2017

briandealwis commented Jul 25, 2017

chanseokoh commented Jul 25, 2017 •

edited

NicolaSpreafico commented Jul 26, 2017

briandealwis commented Jul 27, 2017

chanseokoh commented Jul 27, 2017 •

edited

patflynn commented Jul 27, 2017 via email

chanseokoh commented Jul 28, 2017

chanseokoh commented Jul 31, 2017 •

edited

chanseokoh commented Aug 10, 2017

Use project SDK when staging App Engine apps for deploy #2195

Use project SDK when staging App Engine apps for deploy #2195

Comments

NicolaSpreafico commented Jul 25, 2017

chanseokoh commented Jul 25, 2017

NicolaSpreafico commented Jul 25, 2017

patflynn commented Jul 25, 2017

patflynn commented Jul 25, 2017

chanseokoh commented Jul 25, 2017

loosebazooka commented Jul 25, 2017

briandealwis commented Jul 25, 2017

chanseokoh commented Jul 25, 2017 • edited

NicolaSpreafico commented Jul 26, 2017

briandealwis commented Jul 27, 2017

chanseokoh commented Jul 27, 2017 • edited

patflynn commented Jul 27, 2017 via email

chanseokoh commented Jul 28, 2017

chanseokoh commented Jul 31, 2017 • edited

chanseokoh commented Aug 10, 2017

chanseokoh commented Jul 25, 2017 •

edited

chanseokoh commented Jul 27, 2017 •

edited

chanseokoh commented Jul 31, 2017 •

edited