Service key and project ID emulation settings tab for App Engine local run #2568

chanseokoh · 2017-11-08T20:44:07Z

Only the UI, which is even not visible (not wired). No validation yet —what works is just selecting/retrieving/entering/saving values through UI. The service key path input is particularly incomplete; the browse... button does nothing.

A lot of part is straightforward. However, there is one trick to make things work reasonably sound in the case where an account and a project ID are saved in a run config but the account is not logged in; it was especially tricky to make it right in the run config dialog.

It's loading projects synchronously, but it's not so bad even with a lot of projects. If we do it async in the future, I think we should be very careful. Unlike the deploy panel, I can see many potential pitfalls when doing async in the run config dialog. It's easy to go into the current mess of the Dataflow run config.

…ice-key

elharo · 2017-11-08T21:34:24Z

...ine.localserver/src/com/google/cloud/tools/eclipse/appengine/localserver/messages.properties

@@ -38,3 +38,10 @@ devappserver.not.available=There is no App Engine development server available
 cannot.copy.appengine.api.sdk.jar=Cannot copy appengine-api-1.0-sdk.jar
 server.already.in.operation=Server is already in operation
 server.port=server port: {0,number,\#}
+
+gcp.emulation.tab.name=GCP


Cloud Platform

codecov · 2017-11-09T16:28:48Z

Codecov Report

Merging #2568 into master will increase coverage by 0.3%.
The diff coverage is 79.57%.

@@             Coverage Diff             @@
##             master    #2568     +/-   ##
===========================================
+ Coverage     72.62%   72.93%   +0.3%     
- Complexity     2384     2436     +52     
===========================================
  Files           345      346      +1     
  Lines         13880    14107    +227     
  Branches       1387     1424     +37     
===========================================
+ Hits          10081    10289    +208     
- Misses         3230     3245     +15     
- Partials        569      573      +4

Impacted Files	Coverage Δ	Complexity Δ
...tools/eclipse/projectselector/ProjectSelector.java	`83.83% <100%> (+2.88%)`	`26 <8> (+8)`	⬆️
...oud/tools/eclipse/ui/util/images/SharedImages.java	`88.88% <100%> (-1.12%)`	`1 <1> (ø)`
...lipse/appengine/localserver/ui/GcpLocalRunTab.java	`76.03% <76.03%> (ø)`	`13 <13> (?)`
...oud/tools/eclipse/test/util/BasePluginXmlTest.java	`95.86% <0%> (-1.87%)`	`40% <0%> (+14%)`
...ols/eclipse/projectselector/ProjectRepository.java	`94.36% <0%> (-0.08%)`	`22% <0%> (+9%)`
...tools/eclipse/test/util/ThreadDumpingWatchdog.java	`71.62% <0%> (+6.04%)`	`47% <0%> (+7%)`	⬆️
...ibraries/LibraryClasspathContainerResolverJob.java	`100% <0%> (+25%)`	`4% <0%> (+1%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21f487c...84a333e. Read the comment docs.

briandealwis · 2017-11-09T18:54:33Z

...er.test/src/com/google/cloud/tools/eclipse/appengine/localserver/ui/GcpEmulationTabTest.java

+
+  @Test
+  public void testUiComponents() {
+    assertNotNull(accountSelector);


Should these be at the end of setUp()? At least, I don't see anything that causes the configuration to be different.

briandealwis · 2017-11-09T18:57:44Z

...localserver/src/com/google/cloud/tools/eclipse/appengine/localserver/ui/GcpEmulationTab.java

+import org.eclipse.swt.widgets.Text;
+import org.eclipse.ui.PlatformUI;
+
+public class GcpEmulationTab extends AbstractLaunchConfigurationTab {


GcpEmulationTab seems an odd name — I initially thought it was to do with unit testing. Would GcpProjectTab be more representative?

I agree the name sounds a bit odd. I did thought about GcpProjectTab, but that sounded too broad, while this tab only deals with providing the service key and the project ID for the convenience of users' local development. Any more suggestions?

GcpRuntimeCredentialsTab?

How about GcpLocalRunTab? It's not only for credentials; we have the project field.

briandealwis · 2017-11-09T19:16:39Z

...localserver/src/com/google/cloud/tools/eclipse/appengine/localserver/ui/GcpEmulationTab.java

+  public void initializeFrom(ILaunchConfiguration configuration) {
+    accountEmailModel = getAttribute(configuration, ATTRIBUTE_ACCOUNT_EMAIL, ""); //$NON-NLS-1$
+    gcpProjectIdModel = getAttribute(configuration, ATTRIBUTE_GCP_PROJECT, ""); //$NON-NLS-1$
+    String serviceKey = getAttribute(configuration, ATTRIBUTE_SERVICE_KEY, ""); //$NON-NLS-1$


So what happens if the user also adds a GOOGLE_APPLICATION_CREDENTIALS or GOOGLE_CLOUD_PROJECT value to the environment tab? Which wins?

One approach would be for this tab to actually store and retrieve its values from the launch config's environment data.

I have a comprehensive plan, which I am already doing for Dataflow — it already has an account selector, whose login info is being passed as GOOGLE_APPLICATION_CREDENTIALS. Basically, I will do the following:

https://github.com/GoogleCloudPlatform/google-cloud-eclipse/blob/master/plugins/com.google.cloud.tools.eclipse.dataflow.core/src/com/google/cloud/tools/eclipse/dataflow/core/launcher/DataflowPipelineLaunchDelegate.java#L183

What are you going to do for standard Java launches?

If you store values in the environment, then I think you're done.

What are you going to do for standard Java launches?

I think we can just do the same thing. We anyway have to extend the standard Java run configs to add this tab. I just hope we can also extend the launch delegate so that we can extract values from our tab.

If you store values in the environment, then I think you're done.

That's true, but I'm afraid programmatically adding environment values there may confuse users and actually costs us more complexity in implementation. I think doing in the current manner is much simpler, and I don't see any issue.

Oh, you actually meant adding env vars to the launch config attribute, right? I thought you meant adding env vars to the Environments tab UI. I agree that is what we should do, now knowing that it seems not possible to extend the vanilla-Java launch delegate.

One approach would be for this tab to actually store and retrieve its values from the launch config's environment data.

After some fiddling, I realized this doesn't work nicely, unless we tightly interwire the Environments tab and our tab. For example, suppose the current GOOGLE_APPLICATION_CREDENTIALS is foo.json. This value will be loaded in the service key field in our tab. The user will also be able to see it in the Environments tab. Now, in the Environments tab, suppose the user modifies this value to bar.json. When the user presses Apply, what happens is that the value is immediately reverted back to foo.json, because the framework will call performApply() of our tab as well (even though our tab is invisible). This will overwrite bar.json with foo.json that is in the service key text field. This problem hit me, as I closed the run config right way not knowing that the value was reverted.

Basically, it seems not a good idea for a tab to make changes to a model of a different tab, unless you are willing to update UIs of the other tab simultaneously. I don't think we want to extend the Environments tab to hack this. It won't work in general cases either.

You'll need to go a bit deeper and implement the activated() and deactivated() APIs. That way you'll know when to ignore your text field.

OK, that sounded like a bit of abusing the tab framework, but looks like we can utilize it to make things work reasonably acceptable. This results in some minute annoyances (confirming save even when values have restored to its original state, and another due to #2571), but I think they are pretty insignificant issues.

briandealwis · 2017-11-09T19:18:27Z

...localserver/src/com/google/cloud/tools/eclipse/appengine/localserver/ui/GcpEmulationTab.java

+
+  @Override
+  public void createControl(Composite parent) {
+    Composite composite = new Composite(parent, SWT.NONE);


I wonder if this, and dataflow, should instead have a read-only representation with an Edit… button that pops this up as a dialog. That would avoid the dynamic background updates etc.

That's an attractive idea. I actually thought about having a read-only text field for the project (the account is just for the project selector), which can display the currently saved project even if the user is not logged in. Then we have a "Select Project..." button next to it, which pops up the project selector dialog. I really like this idea considering the benefits from the implementation perspective. The UI is fast because there won't be a long-running project fetch, no async issue in the run config, and a very clean model in the case of users not logged in. @elharo what do you think of this approach?

@elharo likes the idea too, so we can seriously consider going that route. We agreed that we first move forward with this PR (hoping to be able to release this soon) and implement the idea later. I don't think it will be more difficult to do it later than doing it now; it will be changes only in the UI.

patflynn · 2017-11-09T20:10:09Z

I'm noticing that this PR seems to focus on the App Engine standard use-case. I've brought up concerns about that strategy in the design doc that I think should be resolved before we go far down this path.

The focus of this feature was for library users in vanilla (non app-engine std environments)

as a user looking at this UI I would ask myself a lot of questions that would require complex answers. That seems bad.

e.g.

Why is it asking me for a project for local dev, it never used to?
What's a service account? Why do I need one I'm using emulators?

chanseokoh · 2017-11-09T20:22:18Z

I'm noticing that this PR seems to focus on the App Engine standard use-case.

In fact, we are only focusing on the App Engine local run now. This doesn't mean we ignore non-App Engine cases. We just do this for App Engine initially. However, this tab component is designed to be universal — it can be reused in other run configs (such as plain Java run configs). I'll keep this universality in mind.

as a user looking at this UI I would ask myself a lot of questions that would require complex answers.

I've asked the same questions in the design doc. My comment is on the phrase "for selecting the project ID". We can continue our discussion there. I also push for adding something for clarity.

chanseokoh · 2017-11-09T20:31:40Z

However, this tab component is designed to be universal — it can be reused in other run configs (such as plain Java run configs). I'll keep this universality in mind.

For further clarification, there is nothing App Engine-specific in this PR. The tab is for setting a service key and a project ID, which can be applied to any run config.

elharo · 2017-11-10T11:21:13Z

Let's not overthink this. If both the GCP and environment tabs set the credentials/project ID, pick one when launching the server. It's not worth extra effort to keep them in sync.

chanseokoh · 2017-11-10T18:09:59Z

@briandealwis the last commit changes this to save/load values to/from environment variables. PTAL.

briandealwis

A few thoughts below.

briandealwis · 2017-11-10T18:49:41Z

...ver.test/src/com/google/cloud/tools/eclipse/appengine/localserver/ui/GcpLocalRunTabTest.java

+  @Test
+  public void testGetAttribute() throws CoreException {
+    when(launchConfig.getAttribute(eq("attribute-key"), anyString())).thenReturn("expected value");
+    String value = GcpLocalRunTab.getAttribute(launchConfig, "attribute-key", "defualt");


spelling: default

briandealwis · 2017-11-10T19:36:45Z

....localserver/src/com/google/cloud/tools/eclipse/appengine/localserver/ui/GcpLocalRunTab.java

+      }
+      configuration.setAttribute(ILaunchManager.ATTR_ENVIRONMENT_VARIABLES, environmentMap);
+
+      if (environmentTab != null) {


Ugh, this is unfortunate :-(

Would it make sense to move this initializeFrom() to deactivated()? I suppose not, since EnvironmentTab.performApply() may be called in between for other reasons.

That makes sense. But deactivated() always calls performApply(), so there is no difference anyway. Also, I think doing it here is on the safe side and fine.

Actually, I think it's enough to move it into deactivated(). performApply() is called too frequently, and I can't think of any case where we have to update the environment tab before deactivation.

briandealwis · 2017-11-10T19:38:12Z

....localserver/src/com/google/cloud/tools/eclipse/appengine/localserver/ui/GcpLocalRunTab.java

+      configuration.setAttribute(ILaunchManager.ATTR_ENVIRONMENT_VARIABLES, environmentMap);
+
+      if (environmentTab != null) {
+        // Needed to make the "Environment" tab to re-initialize its UI from the changes made here.


I'd add that EnvironmentTab doesn't refresh the environment in its activated(), so we … Ido you want to file a bug against Eclipse Platform/Debug?

It's not clear if it is a bug. Its comment says it won't do anything when activated/deactivated, which is OK from their perspective because everything just works when isolated. It's not working because we are modifying their model in a different tab.

But it's not their model: it's an ILaunchConfiguration that is shared across the tabs.

Filed: https://bugs.eclipse.org/bugs/show_bug.cgi?id=527142

briandealwis · 2017-11-10T19:50:31Z

....localserver/src/com/google/cloud/tools/eclipse/appengine/localserver/ui/GcpLocalRunTab.java

+        updateProjectSelector();
+
+        if (!initializingUiValues) {
+          boolean emptySelection = accountSelector.getSelectedEmail().isEmpty();


accountSelected? empty selection doesn't describe the meaning.

Just realized somethingSelected works better here.

briandealwis · 2017-11-10T19:52:31Z

....localserver/src/com/google/cloud/tools/eclipse/appengine/localserver/ui/GcpLocalRunTab.java

+          boolean savedEmailAvailable = accountSelector.isEmailAvailable(accountEmailModel);
+          if (!emptySelection || savedEmailAvailable) {
+            accountEmailModel = accountSelector.getSelectedEmail();
+            gcpProjectIdModel = ""; //$NON-NLS-1$


Hmm, it would be nice if the selected project was preserved if I change to account that can access the project.

I've fiddled with this issue for quite some time. That behavior would be desirable, but it is not possible to know ahead if the user will ever change back to the previous account to restore the preserved project, or the user really wanted to change the account and then just let the project not selected. (In the latter case, we should not provide a wrong project ID when actually running the server.) So, I think the current state of affair is what we should do, unfortunately.

Ah, I meant:

I select account A1 and project P

I then select A2 which has access to P

P should stay selected.

The case is not so different, and it is difficult to make it right, because it is assumed that the UI and the model are always in sync. Suppose the user changed to A1.5 between A1 and A2. If we could magically anticipate that the user will eventually change to A2 later, we could not clear P. However, if we do not clear P when selecting A1.5 and the user applies the change and exits, we will be wrongly providing P at runtime.

I'm not suggesting retaining the last-selected project when switching A1 → A1.5 → A2. It makes sense that it's cleared.

That said, I'm not sure how often this will occur in practice. It doesn't happen with any of my current projects.

OK, let's leave this as-is. To make your scenario work, the account selector listener has to be coupled with the project selector (because it can only determine the situation after all the projects of A2 are loaded), which doesn't sound worth the effort.

In the end, all the complications and shortcomings will be eliminated by #2571.

briandealwis · 2017-11-10T20:05:43Z

....localserver/src/com/google/cloud/tools/eclipse/appengine/localserver/ui/GcpLocalRunTab.java

+      projectSelector.setProjects(new ArrayList<GcpProject>());
+    } else {
+      try {
+        List<GcpProject> gcpProjects = projectRepository.getProjects(credential);


This is potentially really slow. Perhaps it should be wrapped in a BusyIndicator. See PipelineArgumentsTab#updatePipelineOptionsForm(). (Or the callers should be wrapped.)

briandealwis · 2017-11-10T20:11:29Z

....localserver/src/com/google/cloud/tools/eclipse/appengine/localserver/ui/GcpLocalRunTab.java

+    Label projectLabel = new Label(composite, SWT.LEAD);
+    projectLabel.setText(Messages.getString("label.project")); //$NON-NLS-1$
+
+    Composite projectSelectorComposite = new Composite(composite, SWT.NONE);


I wonder if it makes sense to extract this into a AccountProjectSelectionPanel or something. We use ~~this~~ this combination in a couple of places, like the AppEngineDeployDialog. And #1374 seems like it relevant here too — maybe we should turn ProjectRepository into an injectable service that caches the credential-projects for some period of time.

Indeed, we may decide to do so in the future. For now, the deploy dialog uses databinding, and things work quite differently there (e.g., auto-selecting a single account, it has a refresh button, it has the App Engine application checking and error messages, it has the project creation link, etc); the project selector there is very specialized. So, this would require a substantial work to factor out, so we'd probably want to consider it the next time we need the bare minimum combination similar to the one in this PR.

The cache idea is nice too.

briandealwis · 2017-11-10T20:13:03Z

....localserver/src/com/google/cloud/tools/eclipse/appengine/localserver/ui/GcpLocalRunTab.java

+    setControl(composite);
+
+    gcpIcon = SharedImages.GCP_IMAGE_DESCRIPTOR.createImage();
+    composite.addDisposeListener(new ImageDisposer(gcpIcon));


You can do this by overriding AbstractLaunchConfigurationTab.dispose()

Turns out, the tab lifecycle doesn't seem to match the SWT lifecycle here.

What does this mean — what is the effect? Because with this ImageDisposer, gcpIcon is still left pointing at an invalid object.

Did some more testing. Looks like the tab's dispose() is matched with class instantiation, which is different from that SWT's dispose() is matched with createControl(). I finally decided to make gcpIcon instance-scoped; gcpIcon is now a final field, created only once when the class is created.

briandealwis · 2017-11-10T20:14:11Z

....localserver/src/com/google/cloud/tools/eclipse/appengine/localserver/ui/GcpLocalRunTab.java

+
+  @VisibleForTesting
+  static Map<String, String> getEnvironmentMap(ILaunchConfiguration configuration) {
+    Map<String, String> emptyMap = new HashMap<>();


Collections.emptyMap()

Oh, right, we need a mutable map.

briandealwis · 2017-11-10T20:18:32Z

....localserver/src/com/google/cloud/tools/eclipse/appengine/localserver/ui/GcpLocalRunTab.java

+    String serviceKey = Strings.nullToEmpty(environmentMap.get(SERVICE_KEY_ENVIRONMENT_VARIABLE));
+
+    initializingUiValues = true;
+    accountSelector.selectAccount(accountEmailModel);


I think it's worth mentioning here that the account-selection-event listener updates the project list and waits until complete. Which isn't great for UI liveness, but …

chanseokoh · 2017-11-13T22:17:19Z

I believe all the comments are addressed. PTAL.

briandealwis · 2017-11-14T04:03:54Z

....localserver/src/com/google/cloud/tools/eclipse/appengine/localserver/ui/GcpLocalRunTab.java

+  // To prevent updating above models when programmatically setting up UI components.
+  private boolean initializingUiValues;
+
+  private boolean activated;  // to avoid https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/2568#discussion_r150128582


/** * true if this tab is the currently visible tab * @see #performApply(ILaunchConfigurationWorkingCopy) for details */ `

briandealwis · 2017-11-14T04:09:11Z

....localserver/src/com/google/cloud/tools/eclipse/appengine/localserver/ui/GcpLocalRunTab.java

+        updateProjectSelector();
+
+        if (!initializingUiValues) {
+          boolean somethingSelected = !accountSelector.getSelectedEmail().isEmpty();


accountSelected?

briandealwis · 2017-11-14T04:10:29Z

....localserver/src/com/google/cloud/tools/eclipse/appengine/localserver/ui/GcpLocalRunTab.java

+          boolean somethingSelected = !accountSelector.getSelectedEmail().isEmpty();
+          boolean savedEmailAvailable = accountSelector.isEmailAvailable(accountEmailModel);
+          if (somethingSelected || savedEmailAvailable) {
+            accountEmailModel = accountSelector.getSelectedEmail();


This doesn't seem right: if no account is currently selected, but our saved-email (accountEmailModel) is available, then we throw away our saved-email.

Ohhh! I see: savedEmailAvailable==true means the selector has been populated, and so we now update the accountEmailModel to keep it in sync with changes. A comment would help here, and below for the project selector.

Right. This covers the case where users explicitly de-selected any selection. In this case, we toss the saved value. (Account deselection is not implemented yet, but we do have an issue for this enhancement). I'll add a comment.

briandealwis · 2017-11-14T04:11:02Z

....localserver/src/com/google/cloud/tools/eclipse/appengine/localserver/ui/GcpLocalRunTab.java

+      @Override
+      public void selectionChanged(SelectionChangedEvent event) {
+        if (!initializingUiValues) {
+          boolean somethingSelected = !projectSelector.getSelectProjectId().isEmpty();


projectSelected?

briandealwis · 2017-11-14T04:17:59Z

....localserver/src/com/google/cloud/tools/eclipse/appengine/localserver/ui/GcpLocalRunTab.java

+      return;
+    }
+
+    BusyIndicator.showWhile(Display.getCurrent(), new Runnable() {


Should be able to use serviceKeyInput.getDisplay().

briandealwis · 2017-11-14T04:19:39Z

....localserver/src/com/google/cloud/tools/eclipse/appengine/localserver/ui/GcpLocalRunTab.java

+    String serviceKey = Strings.nullToEmpty(environmentMap.get(SERVICE_KEY_ENVIRONMENT_VARIABLE));
+
+    initializingUiValues = true;
+    // Selecting an account loads projects into the project selector synchronously (via a listener).


Should this be wrapped in a BusyIndicator?

Selecting an account itself should be instant. It is the project selector that makes network calls. So, I put BusyIndicator around the project selector listener.

briandealwis · 2017-11-14T04:19:54Z

....localserver/src/com/google/cloud/tools/eclipse/appengine/localserver/ui/GcpLocalRunTab.java

+
+  @Override
+  public void performApply(ILaunchConfigurationWorkingCopy configuration) {
+    if (!activated) {  // to avoid https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/2568#discussion_r150128582


It's probably best to include a potted summary here, in case these projects are moved elsewhere, or Github disappears.

must avoid updating the environment map unless we're active as performApply() is when the user makes changes in other tabs, like the EnvironmentTab, and thus we could clobber changes made in the EnvironmentTab

briandealwis · 2017-11-14T04:25:29Z

....localserver/src/com/google/cloud/tools/eclipse/appengine/localserver/ui/GcpLocalRunTab.java

+
+  @VisibleForTesting
+  static Map<String, String> getEnvironmentMap(ILaunchConfiguration configuration) {
+    Map<String, String> emptyMap = new HashMap<>();  // should be mutable


This comment is unexpected? An explanation would be useful

Wanted to signify we shouldn't use Collections.emptyMap() which is immutable. I'll update the comment.

briandealwis · 2017-11-14T15:07:06Z

....localserver/src/com/google/cloud/tools/eclipse/appengine/localserver/ui/GcpLocalRunTab.java

@@ -68,6 +67,8 @@
  private static final String SERVICE_KEY_ENVIRONMENT_VARIABLE =
      "GOOGLE_APPLICATION_CREDENTIALS"; //$NON-NLS-1$

+  private final Image gcpIcon = SharedImages.GCP_IMAGE_DESCRIPTOR.createImage();


This approach isn't a good practice as the instance may be created but never used (and hence the image is created unnecessarily), and there's no guarantee that the instance will be created on the SWT thread. Better would be for getImage() to create the image lazily and dispose() to do a check-if-null.

OK, that makes sense. BTW, the image doesn't need to be created on the UI thread.

chanseokoh added 13 commits November 6, 2017 16:32

WIP

f86ae08

Change AccountSelector

844e7b2

Merge branch 'modify-account-selector-ui' into local-run-project-serv…

14cfff1

…ice-key

WIP

7a9db84

WIP

4883686

Now it works

b98b325

Rename var

994c8a9

Add tests

e613ac2

Add tests

91c15e2

Add tests

5525b55

Restore ad-hoc wiring

48dec1b

Merge branch 'master' into local-run-project-service-key

4f2592d

Externalize strings

5e0399b

googlebot added the cla: yes label Nov 8, 2017

Add tests

dbe99e7

elharo reviewed Nov 8, 2017

View reviewed changes

GCP --> Cloud Platform

65f78a6

briandealwis reviewed Nov 9, 2017

View reviewed changes

chanseokoh mentioned this pull request Nov 9, 2017

Read-only presentation of values that require special treatment in run configurations #2571

Open

Rename classes

6c894b8

Save/load into/from environment variables

64e9d51

briandealwis reviewed Nov 10, 2017

View reviewed changes

chanseokoh added 2 commits November 10, 2017 17:40

Address review comments

6315a76

Initialize EnvironmentTab UI in deactivated()

62b4089

chanseokoh added 2 commits November 10, 2017 18:22

Add commens

ad7144a

Revert tab wiring

00cce37

briandealwis reviewed Nov 14, 2017

View reviewed changes

chanseokoh added 2 commits November 14, 2017 00:46

Address review comments

0401011

Remap gcpIcon lifecycle to instance lifecycle

11b82d4

elharo approved these changes Nov 14, 2017

View reviewed changes

briandealwis reviewed Nov 14, 2017

View reviewed changes

chanseokoh added 3 commits November 14, 2017 10:43

Merge branch 'master' into local-run-project-service-key

e3cf4cd

Create Image lazily

434d721

Update comment

84a333e

chanseokoh merged commit 3920923 into master Nov 14, 2017

chanseokoh deleted the local-run-project-service-key branch November 14, 2017 21:16

chanseokoh mentioned this pull request May 17, 2018

Support launching devappserver with user-supplied credential (including CT4E login credentials, service accounts, etc) and project ID used for Veneer libraries #2352

Closed

Service key and project ID emulation settings tab for App Engine local run #2568

Service key and project ID emulation settings tab for App Engine local run #2568

Conversation

chanseokoh commented Nov 8, 2017 • edited

Choose a reason for hiding this comment

codecov bot commented Nov 9, 2017 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chanseokoh Nov 9, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chanseokoh Nov 9, 2017 • edited

Choose a reason for hiding this comment

chanseokoh Nov 9, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

patflynn commented Nov 9, 2017

chanseokoh commented Nov 9, 2017 • edited

chanseokoh commented Nov 9, 2017

elharo commented Nov 10, 2017

chanseokoh commented Nov 10, 2017

briandealwis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chanseokoh Nov 10, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chanseokoh Nov 10, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chanseokoh Nov 14, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

briandealwis Nov 10, 2017 • edited

Choose a reason for hiding this comment

chanseokoh Nov 10, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chanseokoh Nov 10, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chanseokoh Nov 14, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chanseokoh commented Nov 13, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chanseokoh commented Nov 8, 2017 •

edited

codecov bot commented Nov 9, 2017 •

edited

chanseokoh Nov 9, 2017 •

edited

chanseokoh Nov 9, 2017 •

edited

chanseokoh Nov 9, 2017 •

edited

chanseokoh commented Nov 9, 2017 •

edited

chanseokoh Nov 10, 2017 •

edited

chanseokoh Nov 10, 2017 •

edited

chanseokoh Nov 14, 2017 •

edited

briandealwis Nov 10, 2017 •

edited

chanseokoh Nov 10, 2017 •

edited

chanseokoh Nov 10, 2017 •

edited

chanseokoh Nov 14, 2017 •

edited