Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note feature is for 4.5 and 4.6 #434

Merged
merged 1 commit into from Jul 22, 2016
Merged

Note feature is for 4.5 and 4.6 #434

merged 1 commit into from Jul 22, 2016

Conversation

briandealwis
Copy link
Member

Fix #427

@elharo
Copy link
Contributor

elharo commented Jul 22, 2016

LGTM.
Will this work as is with a hypothetical 4.7 release or are we going to need to add a new target platform for each release?

@briandealwis
Copy link
Member Author

It will work with 4.7. But we will need to add a new target for 4.7/Oxygen for testing.

@briandealwis briandealwis merged commit 45616cb into master Jul 22, 2016
@briandealwis briandealwis deleted the i427 branch July 22, 2016 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@elharo elharo

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@briandealwis @elharo @googlebot