-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gke option #31
base: master
Are you sure you want to change the base?
Add gke option #31
Conversation
end | ||
|
||
inst = @config.app["beta_settings"]["cloud_sql_instances"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is GAE specific. Changing this to @config.config[:db_connection_options][:socket].split(":").pop
is a better solution (extracts the Cloud SQL instance name from the required config.yml
).
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
@@ -45,7 +45,8 @@ class Request | |||
# gemserver was deployed to. Optional. | |||
def initialize url = nil, proj_name = nil | |||
gemserver_url = url.nil? == true ? remote(proj_name) : url | |||
@http = Net::HTTP.new gemserver_url | |||
port = Configuration.new.metadata[:platform] == "gke"? 8080 : 80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oddly enough, exposing on port 80 with GKE made the gem server unaccessible. Some additional settings might be necessary in deployment.yaml.base
.
I signed it! (CLA) |
CLAs look good, thanks! |
@dazuma @hxiong388 I have finished adding the tests and doing some cleanup. Feel free to give the GKE implementation a whirl. |
Any update on this ❔ |
Fixes #30