Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gke option #31

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

arhamahmed
Copy link
Contributor

@arhamahmed arhamahmed commented Aug 8, 2017

Fixes #30

end

inst = @config.app["beta_settings"]["cloud_sql_instances"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is GAE specific. Changing this to @config.config[:db_connection_options][:socket].split(":").pop is a better solution (extracts the Cloud SQL instance name from the required config.yml).

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@@ -45,7 +45,8 @@ class Request
# gemserver was deployed to. Optional.
def initialize url = nil, proj_name = nil
gemserver_url = url.nil? == true ? remote(proj_name) : url
@http = Net::HTTP.new gemserver_url
port = Configuration.new.metadata[:platform] == "gke"? 8080 : 80
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oddly enough, exposing on port 80 with GKE made the gem server unaccessible. Some additional settings might be necessary in deployment.yaml.base.

@arhamahmed
Copy link
Contributor Author

arhamahmed commented Aug 22, 2017

I signed it! (CLA)

@googlebot
Copy link

CLAs look good, thanks!

@arhamahmed
Copy link
Contributor Author

arhamahmed commented Aug 22, 2017

@dazuma @hxiong388 I have finished adding the tests and doing some cleanup. Feel free to give the GKE implementation a whirl.

@arhamahmed arhamahmed changed the title [WIP] Add gke option Add gke option Sep 6, 2017
@tmaier
Copy link

tmaier commented Mar 6, 2018

Any update on this ❔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants