Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Add Class Variable Declaration for _backoff_at_millis #154

Merged
merged 1 commit into from Apr 27, 2020
Merged

Add Class Variable Declaration for _backoff_at_millis #154

merged 1 commit into from Apr 27, 2020

Conversation

kevinlutzer
Copy link
Contributor

Setup

  • System: Macbook Air; OSX 0.14.3
  • Arduino: 1.8.12
  • Library Version: 1.1.9

Problem

When I try and compile the Esp8266-lwmqtt code with the library installed via the .zip method I get an error:

error: '_backoff_at_millis' was not declared in this scope
       _backoff_at_millis = millis() + this->__backoff__;

This is because on master the _backoff_at_millis variable is not defined for the CloudIoTCoreMqtt class. I can't replicate when I install the same library version using the Arduino Library Manager, because that version doesn't contain that variable.

Solution

Define _backoff_at_millis in the CloudIoTCoreMqtt class.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@kevinlutzer
Copy link
Contributor Author

@googlebot I signed it

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@DanielGarc
Copy link
Contributor

DanielGarc commented Apr 20, 2020

I think the variable declaration should be an unsigned long since it's compared with millis() returns an unsigned long

Also it should be initialized 0

@Thanasist2
Copy link

Thanasist2 commented Apr 27, 2020

CloudIoTCoreMqtt.h line 31 add -->unsigned long _backoff_at_millis = 0

esp8266/Arduino#6811
#define _stackSize (6748/4)
mine is" BSSL stack: 6132"

Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gguuss gguuss merged commit d55af80 into GoogleCloudPlatform:master Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants