Update CONTRIBUTING.MD for installing #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add suggestions that `mvn install -DskipITs` should be used to skip integration tests when installing. This is to fix #2778.
googlebot
added
the
cla: yes
pongad
reviewed
Feb 7, 2018
CONTRIBUTING.md
Outdated
| @@ -12,7 +12,7 @@ Here are some guidelines for hacking on google-cloud-java. | |||
|
|
|||
| Using maven for build/test | |||
| -------------------------- | |||
| After you cloned the repository use Maven for building and running the tests. | |||
| After you cloned the repository use Maven for building and running the tests. Run `mvn install -DskipITs` to skip integration tests when you install. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM @garrettjonesgoogle PTAL |
CONTRIBUTING.md
Outdated
| @@ -12,7 +12,9 @@ Here are some guidelines for hacking on google-cloud-java. | |||
|
|
|||
| Using maven for build/test | |||
| -------------------------- | |||
| After you cloned the repository use Maven for building and running the tests. | |||
| After you cloned the repository use Maven for building and running the tests. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
PTAL @garrettjonesgoogle |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add suggestions that
mvn install -DskipITsshould be used to skip integration tests when installing.This is to fix #2778.