Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we enable "Require pull request reviews before merging" #2317

Closed
dhermes opened this issue Sep 15, 2016 · 2 comments
Closed

Can we enable "Require pull request reviews before merging" #2317

dhermes opened this issue Sep 15, 2016 · 2 comments
Assignees
@lukesneeringer
Labels
type: question Request for information or clarification. Not an issue.

Comments

@dhermes
Copy link
Contributor

dhermes commented Sep 15, 2016

GitHub recently added the ability to "approve" a PR (instead of typing LGTM). From the branch settings UI:

screen_shot_001

Can we check the box? Though not sure how this works in two situations

  • An owner "approves" their own PR when that is "bad"
  • An owner needs to "approve" their own PR when they need to do an emergency merge
@dhermes dhermes added the type: question Request for information or clarification. Not an issue. label Sep 15, 2016
@dhermes
Copy link
Contributor Author

dhermes commented Sep 15, 2016

This answers the bullet about emergency merges:

screen_shot_002

@lukesneeringer
Copy link
Contributor

lukesneeringer commented Apr 19, 2017 •
edited
Loading

I intend to turn this on very soon. (It is part of a larger initiative I am working on, and I do not need the issue to track it. :-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukesneeringer lukesneeringer

Labels
type: question Request for information or clarification. Not an issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lukesneeringer @jgeewax @dhermes @omaray