Vision: Add batch processing #2978

daspecster · 2017-01-31T18:21:05Z

I wasn't sure the best way to add the context manager to Batch since there needs to be a result returned. I'm not sure of a good way to do that from a context manager's __exit__ without attaching the results to something.

Closes #2897

vision/google/cloud/vision/batch.py

+"""Batch multiple images into one request."""
+
+
+class Batch(object):


vision/google/cloud/vision/batch.py

+        """
+        return self._images
+
+    def detect(self):


vision/google/cloud/vision/_gax.py

@@ -30,24 +30,25 @@ def __init__(self, client=None):
        self._client = client
        self._annotator_client = image_annotator_client.ImageAnnotatorClient()

-    def annotate(self, image, features):
+    def annotate(self, images):


docs/vision-usage.rst

+*********************
+
+Multiple images can be processed with a single request by passing ``Image``s to
+``Client.batch(images)``.


docs/vision-usage.rst

+    >>> batch.add_image(image_one, [face_feature, logo_feature])
+    >>> batch.add_image(image_two, [logo_feature])
+    >>> results = batch.detect()
+    >>> for face in results[0].faces:


system_tests/vision.py

@@ -507,3 +509,53 @@ def test_detect_properties_filename(self):
        image = client.image(filename=FACE_FILE)
        properties = image.detect_properties()
        self._assert_properties(properties)
+
+
+class TestVisionBatchProcessing(BaseVisionTestCase):


vision/google/cloud/vision/_gax.py

@@ -30,24 +30,25 @@ def __init__(self, client=None):
        self._client = client
        self._annotator_client = image_annotator_client.ImageAnnotatorClient()

-    def annotate(self, image, features):
+    def annotate(self, images):


vision/google/cloud/vision/batch.py

+"""Batch multiple images into one request."""
+
+
+class Batch(object):


vision/google/cloud/vision/client.py

@@ -71,6 +72,14 @@ def __init__(self, project=None, credentials=None, http=None,
        else:
            self._use_gax = use_gax

+    def batch(self):
+        """Batch image processing.


daspecster · 2017-02-06T18:35:28Z

I just wanted to check. I think everything was addressed here?

lukesneeringer · 2017-02-09T15:31:43Z

I would still like to understand why annotate's signature changed, but everything else seems good.

daspecster · 2017-02-09T15:47:22Z

@lukesneeringer annotate isn't meant to be used directly. It should probably be named _annotate in hindsight. detect() is the documented method that calls annotate().

That said, the signature change is required because multiple images need to be passed to _vision_api.annotate() in order to build the requests.

You build multiple Request objects and send them as a list and sending them as one request rather than making a request for each image.

Alternatively I could have duplicated the annotate() methods in _http.py and _gax.py and made the changes to handle multiple requests there, but there would have been a decent amount of duplicated code.

lukesneeringer · 2017-02-09T15:55:22Z

Okay, that is fine.

daspecster · 2017-02-09T16:28:52Z

Ok, I'll merge this in an hour or two. There's some other vision work that I want to get closer to finished before I rebase this into it.

* Add Vision batch support to the surface.

Add Vision batch support to the surface.

effc927

daspecster added the api: vision Issues related to the Cloud Vision API. label Jan 31, 2017

daspecster assigned lukesneeringer, tseaver and dhermes Jan 31, 2017

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 31, 2017

lukesneeringer suggested changes Jan 31, 2017

View reviewed changes

lukesneeringer reviewed Jan 31, 2017

View reviewed changes

Reset images after batch detection.

39c7778

daspecster mentioned this pull request Jan 31, 2017

Tracking Vision Development. #2753

Closed

10 tasks

dhermes reviewed Feb 1, 2017

View reviewed changes

Docstring and usage updates.

7832d49

lukesneeringer approved these changes Feb 9, 2017

View reviewed changes

daspecster merged commit db0dc85 into googleapis:master Feb 9, 2017

daspecster deleted the vision-batch-processing-part-2 branch February 9, 2017 17:20

daspecster mentioned this pull request Feb 24, 2017

Upgrading all versions for umbrella release. #3068

Merged

19 tasks

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017

Vision: Add batch processing (googleapis#2978)

3693823

* Add Vision batch support to the surface.

theacodes unassigned dhermes Sep 28, 2018

parthea pushed a commit that referenced this pull request Oct 21, 2023

Vision: Add batch processing (#2978)

c001746

* Add Vision batch support to the surface.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vision: Add batch processing #2978

Vision: Add batch processing #2978

daspecster commented Jan 31, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

daspecster commented Feb 6, 2017

lukesneeringer commented Feb 9, 2017 •

edited

Loading

daspecster commented Feb 9, 2017

lukesneeringer commented Feb 9, 2017

daspecster commented Feb 9, 2017

		"""Batch multiple images into one request."""


		class Batch(object):

Vision: Add batch processing #2978

Vision: Add batch processing #2978

Conversation

daspecster commented Jan 31, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

daspecster commented Feb 6, 2017

lukesneeringer commented Feb 9, 2017 • edited Loading

daspecster commented Feb 9, 2017

lukesneeringer commented Feb 9, 2017

daspecster commented Feb 9, 2017

lukesneeringer commented Feb 9, 2017 •

edited

Loading