Fix race condition in recv()'s usage of self.call. #5935

theacodes · 2018-09-11T21:09:09Z

Fixes #5849

theacodes · 2018-09-11T21:09:23Z

@tseaver I'm not quite done with this, just pushing before I walk out the door.

tseaver · 2018-09-11T21:12:44Z

@theacodes I'll hold off until you ping me, then.

theacodes · 2018-09-12T17:02:43Z

Hrm, it seems circleCI got hung up and timed out, but I can't reproduce it locally yet. I'm gonna re-trigger the build.

theacodes · 2018-09-12T17:03:18Z

AppVeyor did as well.

theacodes · 2018-09-12T17:49:43Z

Alright, @tseaver, this should be ready to review.

pubsub/google/cloud/pubsub_v1/subscriber/_protocol/bidi.py

theacodes requested a review from tseaver September 11, 2018 21:09

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 11, 2018

tseaver added the api: pubsub Issues related to the Pub/Sub API. label Sep 11, 2018

theacodes added 3 commits September 12, 2018 10:54

Testing

c112342

Fix race condition in recv()'s usage of self.call.

df5cc6d

Fixup tests

3f43005

theacodes force-pushed the fix-recv-race-condition branch from febd096 to 3f43005 Compare September 12, 2018 17:54

tseaver reviewed Sep 12, 2018

View reviewed changes

pubsub/google/cloud/pubsub_v1/subscriber/_protocol/bidi.py Show resolved Hide resolved

tseaver approved these changes Sep 12, 2018

View reviewed changes

theacodes merged commit 723b2a3 into master Sep 12, 2018

theacodes deleted the fix-recv-race-condition branch September 12, 2018 22:02

Provide feedback