Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pub/sub: pass transport w/ custom channel to GAPIC API clients. #7008

Merged
merged 2 commits into from
Jan 4, 2019
Merged

Pub/sub: pass transport w/ custom channel to GAPIC API clients. #7008

merged 2 commits into from
Jan 4, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Dec 19, 2018

Silences pending deprecation warnings for passing channel.

Closes #6887.

@tseaver tseaver added api: pubsub Issues related to the Pub/Sub API. type: cleanup An internal cleanup or hygiene concern. labels Dec 19, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 19, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Jan 3, 2019

@theacodes, @crwilcox Rebased against current master: PTAL.

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Jan 4, 2019

The bigtable failure is due to unblackened snippets: I just added #7048 to fix them.

The error reporting failure is due to #6987.

@tseaver
Pass transport w/ custom channel to GAPIC API clients.
2b530a4 
Silences pending deprecation warnings for passing channel.

Closes #6887.
@tseaver
Blacken.
b473ba1
@tseaver
Copy link
Contributor Author

tseaver commented Jan 4, 2019

I've just rebased against the current master to try to isolate the non-pubsub failures.

@tseaver tseaver merged commit a28ef0d into googleapis:master Jan 4, 2019
@tseaver tseaver deleted the 6887-pubsub-remove_channel_deprecation_warning branch January 4, 2019 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes Awaiting requested review from theacodes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tseaver @googlebot @yoshi-kokoro