Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protos as an artifact to library #7205

Merged
merged 21 commits into from
Jan 29, 2019
Merged

Conversation

crwilcox
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 22, 2019
automl/synth.py Outdated Show resolved Hide resolved
bigtable/synth.py Show resolved Hide resolved
container/synth.py Show resolved Hide resolved
datastore/synth.py Show resolved Hide resolved
dlp/synth.py Show resolved Hide resolved
texttospeech/synth.py Outdated Show resolved Hide resolved
trace/synth.py Show resolved Hide resolved
vision/synth.py Outdated Show resolved Hide resolved
websecurityscanner/synth.py Show resolved Hide resolved
bigtable/synth.py Show resolved Hide resolved
@crwilcox
Copy link
Contributor Author

@theacodes @tseaver , I had fanned out using my 'include protos' change and realized it wasn't quite what was desirable. Particularly if didn't work with multiple versions of apis and it wasn't picked up without changing some libraries move paths because it was a new top level folder.

Does this layout work instead? Putting the proto files in the proto dir alongside the *_pb2.py files? I thought having gapic, proto, protos at the next level was undesirable.

@theacodes
Copy link
Contributor

Fine with me. @tseaver?

@tseaver
Copy link
Contributor

tseaver commented Jan 23, 2019

@theacodes, @crwilcox I actually prefer having them in the directory next to the corresponding `_pb2.py' files.

@crwilcox
Copy link
Contributor Author

Sounds good. The way to make this happen in synthtool I have right now isn't ideal, but I will get a PR out for that. I will add the others back to this after that and we can approve it all.

@crwilcox crwilcox merged commit 4e8bc85 into googleapis:master Jan 29, 2019
atulep pushed a commit that referenced this pull request Apr 3, 2023
atulep pushed a commit that referenced this pull request Apr 18, 2023
parthea pushed a commit that referenced this pull request Jun 4, 2023
parthea pushed a commit that referenced this pull request Jun 4, 2023
parthea pushed a commit that referenced this pull request Jun 4, 2023
parthea pushed a commit that referenced this pull request Jul 6, 2023
parthea pushed a commit that referenced this pull request Aug 15, 2023
parthea pushed a commit that referenced this pull request Sep 22, 2023
parthea pushed a commit that referenced this pull request Sep 22, 2023
parthea pushed a commit that referenced this pull request Sep 22, 2023
parthea pushed a commit that referenced this pull request Sep 22, 2023
parthea pushed a commit that referenced this pull request Sep 22, 2023
parthea pushed a commit that referenced this pull request Sep 22, 2023
parthea pushed a commit that referenced this pull request Sep 22, 2023
parthea pushed a commit that referenced this pull request Sep 22, 2023
parthea pushed a commit that referenced this pull request Oct 21, 2023
parthea pushed a commit that referenced this pull request Oct 21, 2023
parthea pushed a commit that referenced this pull request Oct 21, 2023
parthea pushed a commit that referenced this pull request Oct 21, 2023
parthea pushed a commit that referenced this pull request Oct 22, 2023
parthea pushed a commit that referenced this pull request Oct 22, 2023
parthea pushed a commit that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants