Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Language API documentation points to wrong URL #1856

Closed
Merovex opened this issue Nov 24, 2017 · 5 comments
Closed

Google Language API documentation points to wrong URL #1856

Merovex opened this issue Nov 24, 2017 · 5 comments
Assignees
Labels
api: language Issues related to the Cloud Natural Language API API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@Merovex
Copy link

Merovex commented Nov 24, 2017

The Natural Language API Readme points to a dead URL. Correct URL follows.

https://cloud.google.com/natural-language/

@geigerj geigerj self-assigned this Nov 27, 2017
@geigerj geigerj added priority: p2 Moderately-important priority. Fix may not be included in next release. api: language Issues related to the Cloud Natural Language API API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Nov 27, 2017
@geigerj
Copy link
Contributor

geigerj commented Nov 27, 2017

This URL is autogenerated from API metadata in googleapis/googleapis. We should investigate how the canonical URL for product documentation on cloud.google.com is formed, and ensure we generate it correctly from the given metadata. Note that the current link does already redirect to the right URL.

@Merovex
Copy link
Author

Merovex commented Nov 27, 2017

I just checked the link, which led to a 404 page. Perhaps I am clicking the wrong link?

@blowmage
Copy link
Contributor

The URL https://cloud.google.com/language gives me a 404 as well.

@geigerj
Copy link
Contributor

geigerj commented Nov 27, 2017

Thanks for the correction. (Strangely the behavior seems to depend on whether you're inside Google or not...) Filed #1858 as a temporary fix until we can update the code generator.

@geigerj
Copy link
Contributor

geigerj commented Jan 17, 2018

Tracking this issue upstream in the code generator as https://github.com/googleapis/toolkit/issues/1811, and closing this issue. For the time being, we should continue to manually maintain documentation links that the code generator mishandles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: language Issues related to the Cloud Natural Language API API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

3 participants